Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select the hotspot location #55

Closed
4 tasks done
ctwhome opened this issue Apr 16, 2021 · 4 comments
Closed
4 tasks done

Select the hotspot location #55

ctwhome opened this issue Apr 16, 2021 · 4 comments

Comments

@ctwhome
Copy link

ctwhome commented Apr 16, 2021

User story

As an editor
I want to be able to click on the map
So that I can select the position of the hotspot

Proposed work

  • Every time the map is clicked, mode the hotspot location
  • Indicate when are changes (maybe by highlighting the save button?)
  • Show a marker on the map

Acceptance Criteria

  • Persist the changes

Designs

image

@kretep
Copy link
Member

kretep commented Apr 21, 2021

Changes so far at RECEIPT-H2020/terriajs@e1f9e24

@pushpanjalip
Copy link

@kretep I have made some changes to feature/story-editor-hotspot-marker & now hotspot is visible.
But still it just shows marker but does not affect geojson for specific sector.

Quetions to be discussed next sprint:

  • Changing hard coded sectors?
  • If there can be more than 1 sector for specific story then how can we store hotspot for sectors. In current implementation we have sector specific hotspots & geojson. Refer to TerriaMap/wwwroot/public/json/hotspots
  • Do we actually need to change geojson when hotspot location is selected?

@Maartenvm Maartenvm changed the title Select the hostpot location Select the hotspot location Jul 13, 2021
@kretep
Copy link
Member

kretep commented Jul 13, 2021

"Updating the geojson" or " persisting the changes" is now captured in #92 and #93

@goord
Copy link

goord commented Oct 24, 2022

No we have no indication from stakeholders that sectors should be dynamic or storylines could be part of multiple sectors. Let's not overcomplicate things.

@goord goord closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants