Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About fixing the bias in the layers #22

Open
b224618 opened this issue May 5, 2022 · 4 comments
Open

About fixing the bias in the layers #22

b224618 opened this issue May 5, 2022 · 4 comments

Comments

@b224618
Copy link

b224618 commented May 5, 2022

Hi,

Thanks a lot for sharing the code. I have a small question. It seems that the bias of the layers are not masked by the score and not freezed either, and I'm confused about this. Is the bias term different from other trainable parameters (weights)?

Thanks!

@mitchellnw
Copy link
Collaborator

Hello,

Thanks for the question! Do you mean in the convs? We are always setting bias=False in the convs (e.g., https://github.com/RAIVNLab/supsup/blob/master/models/builder.py#L29-L66).

@b224618
Copy link
Author

b224618 commented May 5, 2022

Hi,

Thanks for the quick reply! Now I understand, I have misunderstood the code. By the way, I'm still little bit confused why can't the bias be masked in the same way as the weights?

@mitchellnw
Copy link
Collaborator

Yes, it could! I don't know if that would make much of a difference.

@b224618
Copy link
Author

b224618 commented May 5, 2022

Got it! Thanks a lot for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants