-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 4th digit in version number for CI build number #541
Use 4th digit in version number for CI build number #541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change (but haven't tested it), but please ping me before merging this.
Uh, no merge conflict with #542 merged but I guess this PR still needs to be updated so that run number is written to both exe and dll? Or is this kinda done implicitly already? ^^ |
Correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that version number is set accordingly.
$ exiftool Northstar.dll
ExifTool Version Number : 12.60
File Name : Northstar.dll
...
File Version Number : 0.0.0.2823
Product Version Number : 0.0.0.2823
...
$ exiftool NorthstarLauncher.exe
ExifTool Version Number : 12.60
File Name : NorthstarLauncher.exe
...
File Version Number : 0.0.0.2823
Product Version Number : 0.0.0.2823
...
Didn't test running game but based on the changes this should have no impact.
Code changes look fine, comment was also properly updated.
(I'm still annoyed that it's convention in C to drop the != 0
and rely on truthiness of integers but that's besides the point :P)
closes #369
example of working CI:
https://github.com/ASpoonPlaysGames/NorthstarLauncher/actions/runs/6076234977