Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always allow the local player through the banlist #540

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Always allow the local player through the banlist #540

merged 2 commits into from
Oct 3, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

closes #163

The local player (host) should be exempt from the banlist. Note that this doesn't remove the local player through the banlist, it simply doesn't check if they are banned or not

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 4, 2023
@Alystrasz
Copy link
Contributor

I didn't know Northstar had an integrated banlist mechanism 😄
How can this be tested?

@ASpoonPlaysGames
Copy link
Contributor Author

Get your own UID and add it to banlist.txt, then try to go into the lobby

@Alystrasz
Copy link
Contributor

Get your own UID and add it to banlist.txt, then try to go into the lobby

  • How can I get my own UID?
  • Where's that banlist.txt file?

@ASpoonPlaysGames
Copy link
Contributor Author

  • How can I get my own UID?

sv_cheats 1; script printt( GetPlayerArray()[0].GetUID() ) in lobby should do it I think

  • Where's that banlist.txt file?

Should be just R2Northstar/banlist.txt I believe

Alystrasz
Alystrasz approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and works as expected.
Connection is possible even if local player ID is in the banlist.

Screenshots

Without PR

image

With PR

Connection works as expected:

image

@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 24, 2023
@GeckoEidechse GeckoEidechse changed the title Allow the local player through the banlist Always allow the local player through the banlist Oct 3, 2023
@GeckoEidechse
Copy link
Member

Merging based on reviews.

@GeckoEidechse GeckoEidechse merged commit 1d30b2d into R2Northstar:main Oct 3, 2023
2 checks passed
@ASpoonPlaysGames ASpoonPlaysGames deleted the local-player-ban branch January 4, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alystrasz Alystrasz Alystrasz approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hosting a dedicated server and banning yourself prevents you from opening lobby
3 participants
@ASpoonPlaysGames @Alystrasz @GeckoEidechse