Allow Postload to be used with modded rpaks properly #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing: (ignore example.rpak, thats just another rpak mod i had enabled when i took the screenshot)
|
GeckoEidechse
added
needs testing
Alystrasz
added
the
merge conflicts
|
Is this still an issue? |
Kinda? I don't think anyone actually runs into it in practice, but being unable to load an rpak specifically after another modded rpak is annoying in theory. For testing, see the above comments, nothing about that stuff has changed |
ASpoonPlaysGames
removed
merge conflicts
github-actions
bot
added
the
merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229
This allows Postload to use relative paths for the target rpak, meaning modded rpaks can be used as valid Postload targets.
This is now valid, and will cause the following rpak load order:
common.rpak -> betapulse_preload.rpak -> betapulse.rpak"Postload": { "betapulse_preload.rpak": "common.rpak", "betapulse.rpak": "./betapulse_preload.rpak" }Importantly,
common.rpakis still a valid Postload target, making this not a breaking change for rpak mods"betapulse.rpak": "betapulse_preload.rpak"would also work in this example, however it would load the rpak if another mod loaded an rpak calledbetapulse_preload.rpakwhich could cause problems.