You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The player on the database and pending songs pages is not really very good; it stutters (yes due to UI thread blah blah), occasionally fails to play songs, and has issues with seeking. The old player, based on jPlayer never had these issues.
I suggest that the player is set up as following: If it's FLAC, use flac.js. Otherwise, use jPlayer. There's really no need to use a spotty JS implementation of MP3 decoding when browsers (and flash (suck a duck)) can handle it perfectly well.
This setup should only result in messy code if proper generalizations are not made. All you need is a generic interface for starting, stopping, loading and unified callbacks.
The text was updated successfully, but these errors were encountered:
The player on the database and pending songs pages is not really very good; it stutters (yes due to UI thread blah blah), occasionally fails to play songs, and has issues with seeking. The old player, based on jPlayer never had these issues.
I suggest that the player is set up as following: If it's FLAC, use flac.js. Otherwise, use jPlayer. There's really no need to use a spotty JS implementation of MP3 decoding when browsers (and flash (suck a duck)) can handle it perfectly well.
This setup should only result in messy code if proper generalizations are not made. All you need is a generic interface for starting, stopping, loading and unified callbacks.
The text was updated successfully, but these errors were encountered: