Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain what the heck are Maven Groups in the README #22

Open
EnnuiL opened this issue Nov 23, 2022 · 5 comments
Open

Explain what the heck are Maven Groups in the README #22

EnnuiL opened this issue Nov 23, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@EnnuiL
Copy link
Contributor

EnnuiL commented Nov 23, 2022

While I do suggest the usage of the user's GitHub page as a replacement for one, there is one tiny issue:

  • Maven groups are never properly explained, confusing people in the process
  • The "use your GitHub page if you don't know what it is" trick may work, but it's not really explained, the association of it to Maven groups isn't strong, and it doesn't explain what are Maven groups
  • We need to explain Maven groups
  • That's all :P
@EnnuiL EnnuiL added the enhancement New feature or request label Nov 23, 2022
@Cabbasca
Copy link

the fabric mod template doesn't explain what they are so neither should quilt

@Ecorous
Copy link
Contributor

Ecorous commented Aug 20, 2023

the fabric mod template doesn't explain what they are so neither should quilt

That's effectively saying: fabric is bad so quilt shouldn't be better!!!!

@Cabbasca
Copy link

Cabbasca commented Sep 6, 2023

not really, it shouldn't be necessary to explain stuff in a template mod

@OroArmor
Copy link
Member

OroArmor commented Sep 6, 2023

If it's something we expect people to change it should be something we expect people to know what it is

@lukebemish
Copy link

I definitely agree, this is something the template should explain. I've seen too many mods in the wild using either (a) a completely nonsensical group, (b) a domain they don't own, or (c) something of no relation to the package name they use. Heck, I was personally very confused by group and package naming when I first did java/modding stuff, coming to it from outside the ecosystem. Explaining that the maven group name is similar to the package name prefix in terms of what you should use, and explaining options for what to use for both, is a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants