Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the LICENSE renaming in order to account for the file extension #19

Open
EnnuiL opened this issue Oct 16, 2022 · 6 comments
Open

Comments

@EnnuiL
Copy link
Contributor

EnnuiL commented Oct 16, 2022

On QTM, LICENSE.md is to be considered a valid alternative to the good ol' LICENSE, but if you do try it, the renamed LICENSE will become something like LICENSE.md_example_mod, which is bad

@triphora
Copy link
Contributor

README doesn't get included in the jar by default...
Besides, you don't have to rename it, you just do from 'README.md' and you're done

@EnnuiL
Copy link
Contributor Author

EnnuiL commented Oct 16, 2022

README doesn't get included in the jar by default... Besides, you don't have to rename it, you just do from 'README.md' and you're done

The buildscript does include it, although the README rename is something inherited from Fabric Example Mod, which I assume it's for clarifying what the LICENSE file belongs to; Although thinking about it? It's only really relevant if you actually include more than one README file which in that case, yeah, it should be added manually

@triphora
Copy link
Contributor

The buildscript does include it,

Show me where it does that. It doesn't.

@EnnuiL
Copy link
Contributor Author

EnnuiL commented Oct 16, 2022

The buildscript does include it,

Show me where it does that. It doesn't.

Yes, like I said, the buildscript does include the LICENSE file, and I don't see why we wouldn't do that

@EnnuiL
Copy link
Contributor Author

EnnuiL commented Oct 16, 2022

...🤦‍♀️ I failed at communication; When I said README, I meant LICENSE; i sure love my brain

@EnnuiL EnnuiL changed the title Adapt the README renaming in order to account for the file extension Adapt the LICENSE renaming in order to account for the file extension Oct 16, 2022
@EnnuiL EnnuiL closed this as completed in d7b53f6 Oct 24, 2022
@EnnuiL EnnuiL reopened this Jan 14, 2023
@EnnuiL
Copy link
Contributor Author

EnnuiL commented Jan 14, 2023

Unfortunately, the attempted solution failed... It has been reverted for now, but yeah, an equivalent one that actually works should be investigated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants