pipewire: prevent starting in root session

[marmarek]

If root session is started early and pipewire gets started as part of
it, it may connect to the audiovm earlier than the user's instance,
effectively stealing the connection. Upstream already has
ConditionUser=!root in relevant pulseaudio units, but not in pipewire
ones. Add similar condition to pipewire.service unit.

Fixes QubesOS/qubes-issues#9619

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024121004-4.3&flavor=pull-requests

Test run included the following:

• pipewire: prevent starting in root session #220 (7be8161)
• Improve handling early startup issues #219 (0ad1350)
• Various test improvement, especially for testing minimal templates qubes-core-admin#639 (QubesOS/qubes-core-admin@301f33d)
• tests: try dracut on Debian too qubes-core-admin#638 (QubesOS/qubes-core-admin@5b7e57b)
• Make "multimedia" devices more detailed qubes-core-admin-client#322 (QubesOS/qubes-core-admin-client@95a2f69)
• DEBUG: log stdout/err from updates check on Debian qubes-core-agent-linux#537 (QubesOS/qubes-core-agent-linux@81954b6)
• Honor NoDisplay=true qubes-desktop-linux-menu#52 (QubesOS/qubes-desktop-linux-menu@9586eda)
• Add dracut config to the Debian package too qubes-core-agent-linux#536 (QubesOS/qubes-core-agent-linux@e9e5b81)
• Layer shell support qubes-desktop-linux-menu#53 (QubesOS/qubes-desktop-linux-menu@8d2ebd7)
• audio: fix reacting on mic enable/disable requests qubes-gui-daemon#161 (QubesOS/qubes-gui-daemon@0030c81)
• Retire old qubes-vm-create dialog qubes-manager#393 (QubesOS/qubes-manager@210f867)
• Escape application names for GMarkup qubes-desktop-linux-menu#51 (QubesOS/qubes-desktop-linux-menu@b2e036c)
• Try to retrieve exit code of a failed service call qubes-core-qrexec#183 (QubesOS/qubes-core-qrexec@66c1519)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update

• system_tests_extra

  • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: wait_serial (wait serial expected)
    # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

Failed tests

5 failures

• system_tests_extra

  • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

  • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: wait_serial (wait serial expected)
    # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • gui_keyboard_layout: Failed (test died)
    # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

• system_tests_basic_vm_qrexec_gui_zfs

  • switch_pool: Failed (test died)
    # Test died: command 'dnf install -y ./zfs-release.rpm' failed at /...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/119126#dependencies

1 fixed

• system_tests_audio@hw1
  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_260_audio_mic_enabled_switch_audiovm (failure)
    AssertionError: too short audio, expected 10s, got 0.00013605442176...

Unstable tests

• system_tests_basic_vm_qrexec_gui_zfs

  TC_00_Basic/test_120_start_standalone_with_cdrom_dom0 (1/5 times with errors)

  • job 109480 AssertionError: 1 != 0 : b'Timeout waiting for dom0:loop6 device to...

• system_tests_audio

  TC_20_AudioVM_PipeWire_fedora-40-xfce/test_260_audio_mic_enabled_switch_audiovm (1/5 times with errors)

  • job 117586 AssertionError: too short audio, expected 10s, got 0.00013605442176...

• system_tests_audio@hw1

  TC_20_AudioVM_PipeWire_fedora-40-xfce/test_260_audio_mic_enabled_switch_audiovm (1/5 times with errors)

  • job 117586 AssertionError: too short audio, expected 10s, got 0.00013605442176...

[DemiMarie]

Should there be a similar check for WirePlumber?

[marmarek]

wireplumber has BindsTo=pipewire, so it should be implicit already; but even if not, just wireplumber is harmless.