-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EntanglementConsumer #86
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 71.33% 71.34% +0.01%
==========================================
Files 37 37
Lines 1493 1525 +32
==========================================
+ Hits 1065 1088 +23
- Misses 428 437 +9 ☔ View full report in Codecov by Sentry. |
With the query specification as fifo, we don't have issues with outdated history tags and we can run Entangler and Swapper for infinite rounds. But a new issue comes out of this, where we have deadlock in the network due to a leftward node (say, node 2) having all its slots entangled with a single or multiple nodes only in the right(3, 4,...). This way, no swap can occur since we need a node in the left and one in the right to do a swap. Neither is it able to generate new entanglement with nodes on left since its slots can't be freed from entanglement with right nodes due to no swaps. If you check the log in buildkite, the end is all about entanglement attempts failing |
Tests seem to be failing -- could you fix that? It makes reviewing much faster if the tests pass/ If it is because of a ton of noise in the logs due to warnings from SumTypes, you can add the same addition you had in #92 |
The FIFO/FILO changes look good. I have not looked into the consumer in detail yet. |
Benchmark ResultJudge resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
Benchmark ResultJudge resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
Benchmark ResultJudge resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
|
edc77ab
to
b6163ff
Compare
This looks great! I made a couple of minor changes, hopefully did not break anything. I will plan to merge shortly. |
Thanks for fixing the issues I introduced! |
EntanglementConsumer protocol for network simulations. Currently it uses
query
anduntag
and we empty the qubits manually by zeroing the stateindices and setting the staterefs to nothing for the slots, just for initial testing