Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups for examples related to repeatergrid #148

Open
3 tasks
Krastanov opened this issue Sep 6, 2024 · 0 comments
Open
3 tasks

Fixups for examples related to repeatergrid #148

Krastanov opened this issue Sep 6, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Krastanov
Copy link
Member

On preparing for merging #120 this was unfinished (better to fix it in a separate PR though):

  • repeatergrid.md is not included in the rendered documentation (from the make.jl file)
  • the webgl repeatergrid example does not start (the run button reacts, but no simulation runs)
  • the gl repeatergrid example does not use its sliders -- the easiests solution is probably to just remove the sliders (and some easy-to-edit global variables should be declared instead of them)

The above are bugs that should be fixed. A "nice to have" would be to also DRY-out the code -- the four example files are very repetitive. That is not a priority though.

@Krastanov Krastanov added the bug Something isn't working label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants