-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noisy Circuits Improvements #449
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Stefan Krastanov <[email protected]>
…mClifford.jl into loc-comm-embed fixed merge conflict with origin
…cally for you, causing less noise in PRs)
Hi Isaac, It seems the merge conflicts might have arisen because commits from your previous PR have resurfaced.
With regards to your mermaid schematic link:
For implementation, embed the Mermaid chart within Here's an example of the syntax for docstring rendering:
It’s just my observation, but using the default color palette in Mermaid allows it to render nicely in both dark mode and light mode without any additional adjustments. However, if you choose to apply your own custom color scheme, you’ll need to verify how it appears in both light and dark modes to ensure it looks good across both themes. Regarding the addition of a Mermaid schematic, you can refer to QuantumSavory for inspiration: https://quantumsavory.github.io/QuantumSavory.jl/stable/register_interface/. On a related note, click the ⚙️ button, select "documenter-dark" if you are not using dark mode and let me know if all the boxes in the QS Mermaid charts are clearly readable. I am unable to read the text in white for Mermaid charts in the aforementioned link in dark mode. I've switched browsers and operating systems, but this issue still occurs when using dark mode or documenter-dark mode. Apologies for the slight digression. Edit: This is due to the |
Improving and documenting
pretrajectories
and related functionalityIf you want to submit an unfinished piece of work in order to get comments and discuss, please mark the pull request as a draft and ping the repository maintainer.
Please address only one topic or issue per pull request! Many small PRs are much easier to review and merge than one large PR.
Before merging, all changes and new functionality should be marked in the CHANGELOG file, but feel free to just leave your CHANGELOG notes in the PR description, to avoid merge conflicts with other requests modifying that file. The maintainer will add these CHANGELOG notes for you if you do so.
Before considering your pull request ready for review and merging make sure that all of the following are completed (please keep the clecklist as part of your PR):
If possible, keep your git history not too wild (rebase and squash commits, keep commits small and semantically separated) so that review is easier.