Add Oscar as weak dep to enable rich GroupAlgebra and GAP support

QuantumSavory · Oct 8, 2024 · a5c1426 · a5c1426
1 parent 4e06c01
commit a5c1426
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -27,14 +27,15 @@ CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
 Hecke = "3e1990a7-5d81-5526-99ce-9ba3ff248f21"
 LDPCDecoders = "3c486d74-64b9-4c60-8b1a-13a564e77efb"
 Makie = "ee78f7c6-11fb-53f2-987a-cfe4a2b5a57a"
+Oscar = "f1435218-dba5-11e9-1e4d-f1a5fab5fc13"
 Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
 PyQDecoders = "17f5de1a-9b79-4409-a58d-4d45812840f7"
 Quantikz = "b0d11df0-eea3-4d79-b4a5-421488cbf74b"
 QuantumOpticsBase = "4f57444f-1401-5e15-980d-4471b28d5678"
 
 [extensions]
 QuantumCliffordGPUExt = "CUDA"
-QuantumCliffordHeckeExt = "Hecke"
+QuantumCliffordHeckeExt = ["Hecke", "Oscar"]
 QuantumCliffordLDPCDecodersExt = "LDPCDecoders"
 QuantumCliffordMakieExt = "Makie"
 QuantumCliffordPlotsExt = "Plots"
@@ -48,15 +49,16 @@ Combinatorics = "1.0"
 DataStructures = "0.18"
 DocStringExtensions = "0.9"
 Graphs = "1.9"
-Hecke = "0.28, 0.29, 0.30, 0.31, 0.32, 0.33, 0.34"
+Hecke = "0.29, 0.30, 0.31, 0.32, 0.33, 0.34, 0.34.3"
 HostCPUFeatures = "0.1.6"
 ILog2 = "0.2.3"
 InteractiveUtils = "1.9"
 LDPCDecoders = "0.3.1"
 LinearAlgebra = "1.9"
 MacroTools = "0.5.9"
 Makie = "0.20, 0.21"
-Nemo = "0.42.1, 0.43, 0.44, 0.45, 0.46, 0.47"
+Nemo = "0.43, 0.44, 0.45, 0.46, 0.47, 0.47.1"
+Oscar = "1.1.0, 1.1.1"
 Plots = "1.38.0"
 PrecompileTools = "1.2"
 PyQDecoders = "0.2.1"

diff --git a/ext/QuantumCliffordHeckeExt/QuantumCliffordHeckeExt.jl b/ext/QuantumCliffordHeckeExt/QuantumCliffordHeckeExt.jl
@@ -8,6 +8,8 @@ import Hecke: Group, GroupElem, AdditiveGroup, AdditiveGroupElem,
     multiplication_table, coefficients, abelian_group, group_algebra
 import Nemo
 import Nemo: characteristic, matrix_repr, GF, ZZ, lift
+import Oscar
+import Oscar: direct_product, PcGroup, SubPcGroup
 
 import QuantumClifford.ECC: AbstractECC, CSS, ClassicalCode,
     hgp, code_k, code_n, code_s, iscss, parity_checks, parity_checks_x, parity_checks_z, parity_checks_xz,

diff --git a/test/Project.toml b/test/Project.toml
@@ -16,6 +16,7 @@ LDPCDecoders = "3c486d74-64b9-4c60-8b1a-13a564e77efb"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 MacroTools = "1914dd2f-81c6-5fcd-8719-6d5c9610ff09"
 Nemo = "2edaba10-b0f1-5616-af89-8c11ac63239a"
+Oscar = "f1435218-dba5-11e9-1e4d-f1a5fab5fc13"
 PyQDecoders = "17f5de1a-9b79-4409-a58d-4d45812840f7"
 Quantikz = "b0d11df0-eea3-4d79-b4a5-421488cbf74b"
 QuantumInterface = "5717a53b-5d69-4fa3-b976-0bf2f97ca1e5"

diff --git a/test/test_ecc_base.jl b/test/test_ecc_base.jl
@@ -6,6 +6,7 @@ using InteractiveUtils
 import Nemo: GF
 import LinearAlgebra
 import Hecke: group_algebra, abelian_group, gens
+import Oscar
 
 # generate instances of all implemented codes to make sure nothing skips being checked