Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contraction order optimization for LocalOperator contractions #114

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

pbrehmer
Copy link
Collaborator

@pbrehmer pbrehmer commented Jan 10, 2025

We fix the contraction order optimization in _contract_localoperator and _contract_localnorm by renaming the indices and using @autoopt.

@pbrehmer pbrehmer requested a review from lkdvos January 10, 2025 14:03
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 98.55072% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/algorithms/contractions/localoperator.jl 98.55% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/algorithms/contractions/localoperator.jl 94.94% <98.55%> (+1.37%) ⬆️

@lkdvos lkdvos force-pushed the pb-fix-localoperator-contraction branch from f9a1512 to ad75752 Compare January 10, 2025 16:42
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I took the time to also just refactor the code a bit, there was quite a bit of duplication etc, I would argue it reads a lot nicer now.
If tests turn green, good to go for me!

@pbrehmer pbrehmer enabled auto-merge January 10, 2025 17:25
@pbrehmer
Copy link
Collaborator Author

The refactor looks very nice, thanks for that!

@pbrehmer pbrehmer merged commit 69ae4d3 into master Jan 10, 2025
27 checks passed
@pbrehmer pbrehmer deleted the pb-fix-localoperator-contraction branch January 10, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants