Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated approximate method for variational truncation of an AbstractMPS #94

Open
leburgel opened this issue Nov 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@leburgel
Copy link
Contributor

It might be useful to add a dedicated approximate(Ψ₀::AbstractMPS, Ψ::AbstractMPS, algorithm, [environments]; kwargs...) method for a globally optimal truncation of a given MPS. It is mentioned in the changebonds documentation that combining changebonds(Ψ::AbstractMPS, alg::SvdCt) with approximate can give a globally optimal truncation, but as far as I can tell all current implementations of approximate take an MPO-MPS pair as the object to approximate, so I don't see how this could be done directly.

@lkdvos lkdvos added the enhancement New feature or request label Dec 1, 2023
@maartenvd
Copy link
Collaborator

To tag on to this, should we change the approximate call signature to not take in tuples? I'm not sure why I started doing that, but at the moment it certainly doesn't look so clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants