Update Binance Futures account & balance API to v2 (#27)

QuantConnect · Sep 18, 2023 · 08bcb21 · 08bcb21
1 parent c00cc44
commit 08bcb21
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/QuantConnect.BinanceBrokerage/BinanceBaseRestApiClient.cs b/QuantConnect.BinanceBrokerage/BinanceBaseRestApiClient.cs
@@ -141,10 +141,19 @@ public virtual List<Holding> GetAccountHoldings()
         /// Gets the total account cash balance for specified account type
         /// </summary>
         /// <returns></returns>
-        public BalanceEntry[] GetCashBalance()
+        public virtual BalanceEntry[] GetCashBalance()
+        {
+            return GetCashBalance(ApiPrefix);
+        }
+
+        /// <summary>
+        /// Gets the total account cash balance for specified account type
+        /// </summary>
+        /// <returns></returns>
+        protected BalanceEntry[] GetCashBalance(string apiPrefix)
         {
             var queryString = $"timestamp={GetNonce()}";
-            var endpoint = $"{ApiPrefix}/account?{queryString}&signature={AuthenticationToken(queryString)}";
+            var endpoint = $"{apiPrefix}/account?{queryString}&signature={AuthenticationToken(queryString)}";
             var request = new RestRequest(endpoint, Method.GET);
             request.AddHeader(KeyHeader, ApiKey);
 

diff --git a/QuantConnect.BinanceBrokerage/BinanceFuturesRestApiClient.cs b/QuantConnect.BinanceBrokerage/BinanceFuturesRestApiClient.cs
@@ -75,7 +75,7 @@ string restApiUrl
         public override List<Holding> GetAccountHoldings()
         {
             var queryString = $"timestamp={GetNonce()}";
-            var endpoint = $"{ApiPrefix}/account?{queryString}&signature={AuthenticationToken(queryString)}";
+            var endpoint = $"/fapi/v2/account?{queryString}&signature={AuthenticationToken(queryString)}";
             var request = new RestRequest(endpoint, Method.GET);
             request.AddHeader(KeyHeader, ApiKey);
 
@@ -97,5 +97,10 @@ public override List<Holding> GetAccountHoldings()
                 })
                 .ToList();
         }
+
+        public override BalanceEntry[] GetCashBalance()
+        {
+            return GetCashBalance("/fapi/v2");
+        }
     }
 }