-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider handling rzz validation for parametrized angles #2000
Comments
I want to change the signature of @jyu00 @kevinsung @mberna Does it require deprecation? To be on the safe side, for now I'll leave ISA validation unchanged. I'll add two new functions, |
I don't really work on this repository, perhaps you mean to ping @kt474 . |
It's not an API break since |
Following #2035, we should also take into account parameter expressions. |
rzz
angle is allowed only in the range[0, pi/2]
.If a user writes
rzz(-1, qubit)
orrzz(3, qubit)
(i.e., the angle is a number) then our ISA validation will correctly fail.But, if the user writes
rzz(param, qubit)
, where param is aqiskit.circuit.Parameter
, and assigns a negative (or greater than pi/2) value to the parameter - this will not be caught by the validation process, and therefore will fail much later in the stack.The text was updated successfully, but these errors were encountered: