Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tenpy] lift the conserve="Sz" requirement #36

Open
mrossinek opened this issue Nov 21, 2024 · 0 comments
Open

[tenpy] lift the conserve="Sz" requirement #36

mrossinek opened this issue Nov 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mrossinek
Copy link
Member

Currently, the tenpy backends require Sz conservation. We should consider lifting this limitation.

# TODO: currently, this default Sz conservation is coupled to the LegCharge definition in
# MPOState.initialize_from_lattice. Not conserving Sz errors with 'Different ChargeInfo'.

Currently, the LayerModel.init_sites method defaults to conserve="Sz" for the SpinHalfSite objects being created. While one can theoretically overwrite this via the model_params, setting it to None currently breaks the leg-charges of the initial MPO state. This has to be addressed here:

# FIXME: the following is supposed to allow `conserve=None` for our `SpinHalfSite` but it
# does not seem to work, even in the `conserve="Sz"` case.

@mrossinek mrossinek added the enhancement New feature or request label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant