Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image slider effect is created in the home section. #380

Closed
wants to merge 3 commits into from
Closed

image slider effect is created in the home section. #380

wants to merge 3 commits into from

Conversation

jugeshraghav
Copy link
Contributor

@jugeshraghav jugeshraghav commented Jun 26, 2021 •
edited
Loading

Issue Number

fixes #56

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Additional context (OPTIONAL)

Add any other context or screenshots about the feature request here.

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.
How someone can test your code?

Checklist

  • I have added my name in the contributors list at the end of README.md file.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.
  • Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

@jugeshraghav
Copy link
Contributor Author

@QAZIMAAZARSHAD please look at it and suggest me if any changes are possible.

@QAZIMAAZARSHAD
Copy link
Owner

Share a screenshot and live demo link,

@jugeshraghav
Copy link
Contributor Author

on clicking the buttons the images will scroll left and right.

@jugeshraghav
Copy link
Contributor Author

ApnaTheatre.-.Google.Chrome.2021-06-26.14-34-11_Trim.mp4

@QAZIMAAZARSHAD
Copy link
Owner

Apply this on every page, every section.

Check flip effect and responsiveness as well.

@jugeshraghav
Copy link
Contributor Author

jugeshraghav commented Jun 26, 2021 via email

@jugeshraghav
Copy link
Contributor Author

Hi @QAZIMAAZARSHAD I was thinking to change the buttons from circular shape to rectangular shape. what do you think about it?

@QAZIMAAZARSHAD
Copy link
Owner

Sure,

Try to make it transparent, or unnoticeable like on the kids' page. You can do whatever you want as long as it looks nice.

@saimanoharhm
Copy link

@jugeshraghav Any update? If you face issue in the code let me know with your problem I am here to help you out.

@jugeshraghav
Copy link
Contributor Author

hii @QAZIMAAZARSHAD I have created the slider in all the pages where it was needed. please have a look and suggest me changes if there.

@jugeshraghav
Copy link
Contributor Author

@saimanoharhm i don,t know how but the problem is resolved. Thank you so much.

@QAZIMAAZARSHAD
Copy link
Owner

@jugeshraghav share the website link so I can review your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace movie cards by carousel view in all the sections of home page
3 participants
@jugeshraghav @QAZIMAAZARSHAD @saimanoharhm