Pool certificates #321
Merged
Pool certificates #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and network args method to use custom networks
add initial stake pool registration flag and deposit add pool vkey hashes if certificate exists
# Conflicts: # pycardano/backend/cardano_cli.py # test/pycardano/backend/test_cardano_cli.py
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 83.12% 83.42% +0.30%
==========================================
Files 28 29 +1
Lines 3443 3705 +262
Branches 844 929 +85
==========================================
+ Hits 2862 3091 +229
- Misses 430 448 +18
- Partials 151 166 +15 ☔ View full report in Codecov by Sentry. |
|
Thanks a ton for adding support for pool certificates! The changes look good overall. There are a few test cases failed when using python3 versions less than |
Syntax "Optional[type1 | type2]" is not supported in version <= 3.9
cffls
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got around to cleaning up and writing some tests for the code to handle pool certificates as mentioned in #280.
This handles
PoolRegistrationandPoolRetirementCertificates. They can be added to transactions, and parsing transactions that contain them will now work correctly.When registering a pool for the first time, the
TransactionBuilderhas a boolean value calledinitial_stake_pool_registrationthat can be set to true to add the pool deposit to the transaction.I also added another boolean value called
witness_overrideto theTransactionBuilder, which overrides the witness count when estimating the transaction fee. This is very useful for building transactions that multiple parties will sign and witness later.