From 2d78f7b538f825df6a38d3c30a9276d10869aa5b Mon Sep 17 00:00:00 2001
From: Mihitoko <max-lotz@outlook.de>
Date: Fri, 13 Oct 2023 14:46:24 +0200
Subject: [PATCH] add assertions to test right serialization of command

---
 tests/test_typing_annotated.py | 48 +++++++++++++++++++++++++++++-----
 1 file changed, 42 insertions(+), 6 deletions(-)

diff --git a/tests/test_typing_annotated.py b/tests/test_typing_annotated.py
index 582bd4f8a0..0ea4125f02 100644
--- a/tests/test_typing_annotated.py
+++ b/tests/test_typing_annotated.py
@@ -1,10 +1,9 @@
 from typing import Optional
 
-import pytest
 from typing_extensions import Annotated
 
 import discord
-from discord import ApplicationContext
+from discord import SlashCommandOptionType
 from discord.commands.core import SlashCommand, slash_command
 
 
@@ -15,6 +14,8 @@ async def echo(ctx, txt: Annotated[str, discord.Option()]):
     cmd = SlashCommand(echo)
     bot = discord.Bot()
     bot.add_application_command(cmd)
+    dict_result = cmd.to_dict()
+    assert dict_result.get("options")[0].get("type") == SlashCommandOptionType.string.value
 
 
 def test_typing_annotated_decorator():
@@ -24,6 +25,12 @@ def test_typing_annotated_decorator():
     async def echo(ctx, txt: Annotated[str, discord.Option(description="Some text")]):
         await ctx.respond(txt)
 
+    dict_result = echo.to_dict()
+
+    option = dict_result.get("options")[0]
+    assert option.get("type") == SlashCommandOptionType.string.value
+    assert option.get("description") == "Some text"
+
 
 def test_typing_annotated_cog():
     class echoCog(discord.Cog):
@@ -33,12 +40,19 @@ def __init__(self, bot_) -> None:
 
         @slash_command()
         async def echo(
-            self, ctx, txt: Annotated[str, discord.Option(description="Some text")]
+                self, ctx, txt: Annotated[str, discord.Option(description="Some text")]
         ):
             await ctx.respond(txt)
 
     bot = discord.Bot()
-    bot.add_cog(echoCog(bot))
+    cog = echoCog(bot)
+    bot.add_cog(cog)
+
+    dict_result = cog.echo.to_dict()
+
+    option = dict_result.get("options")[0]
+    assert option.get("type") == SlashCommandOptionType.string.value
+    assert option.get("description") == "Some text"
 
 
 def test_typing_annotated_cog_slashgroup():
@@ -51,12 +65,19 @@ def __init__(self, bot_) -> None:
 
         @grp.command()
         async def echo(
-            self, ctx, txt: Annotated[str, discord.Option(description="Some text")]
+                self, ctx, txt: Annotated[str, discord.Option(description="Some text")]
         ):
             await ctx.respond(txt)
 
     bot = discord.Bot()
-    bot.add_cog(echoCog(bot))
+    cog = echoCog(bot)
+    bot.add_cog(cog)
+
+    dict_result = cog.echo.to_dict()
+
+    option = dict_result.get("options")[0]
+    assert option.get("type") == SlashCommandOptionType.string.value
+    assert option.get("description") == "Some text"
 
 
 def test_typing_annotated_optional():
@@ -67,6 +88,11 @@ async def echo(ctx, txt: Annotated[Optional[str], discord.Option()]):
     bot = discord.Bot()
     bot.add_application_command(cmd)
 
+    dict_result = cmd.to_dict()
+
+    option = dict_result.get("options")[0]
+    assert option.get("type") == SlashCommandOptionType.string.value
+
 
 def test_no_annotation():
     async def echo(ctx, txt: str):
@@ -76,6 +102,11 @@ async def echo(ctx, txt: str):
     bot = discord.Bot()
     bot.add_application_command(cmd)
 
+    dict_result = cmd.to_dict()
+
+    option = dict_result.get("options")[0]
+    assert option.get("type") == SlashCommandOptionType.string.value
+
 
 def test_annotated_no_option():
     async def echo(ctx, txt: Annotated[str, "..."]):
@@ -84,3 +115,8 @@ async def echo(ctx, txt: Annotated[str, "..."]):
     cmd = SlashCommand(echo)
     bot = discord.Bot()
     bot.add_application_command(cmd)
+
+    dict_result = cmd.to_dict()
+
+    option = dict_result.get("options")[0]
+    assert option.get("type") == SlashCommandOptionType.string.value