Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider remove ConceptNet live internet request #995

Open
bact opened this issue Nov 13, 2024 · 1 comment
Open

Consider remove ConceptNet live internet request #995

bact opened this issue Nov 13, 2024 · 1 comment

Comments

@bact
Copy link
Member

bact commented Nov 13, 2024

Description

The internet request of conceptnet function made the test unreliable,
as if the internet connection is bad, it will time out and make the function failed.

A function should be self-contained within a local machine.
A download can be made but not a constant internet call.

Expected results

ConceptNet features run locally.

Current results

ConceptNet features made internet connection everytime.

Steps to reproduce

Call ConceptNet features. For example,

conceptnet.edges("รัก")

PyThaiNLP version

5.0.4

Python version

Any

Operating system and version

Any

More info

No response

Possible solution

No response

Files

No response

@bact bact added this to PyThaiNLP Nov 13, 2024
@bact bact moved this to To do in PyThaiNLP Nov 13, 2024
@wannaphong
Copy link
Member

I think we can use ConceptNet-Lite. It can work in offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

No branches or pull requests

2 participants