Fix regressions for black #2339
Open
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2339 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 40 40
Lines 3096 3096
Branches 787 787
=======================================
Hits 3069 3069
Misses 15 15
Partials 12 12 |
|
The change from #2236 looks to not play nice when using diff --git a/tests/unit/profiles/test_black.py b/tests/unit/profiles/test_black.py
index 8f750100..027ebce4 100644
--- a/tests/unit/profiles/test_black.py
+++ b/tests/unit/profiles/test_black.py
@@ -456,3 +456,15 @@ def test_black_trailing_comma():
)
""",
)
+
+def test_black_trailing_comma2():
+ black_test(
+ """\
+from x import ( a as b,)
+""",
+ """\
+from x import (
+ a as b,
+)
+""",
+ ) |
|
maybe there's an existing bug with diff --git a/tests/unit/test_isort.py b/tests/unit/test_isort.py
index ddfa4e24..9d237128 100644
--- a/tests/unit/test_isort.py
+++ b/tests/unit/test_isort.py
@@ -5559,11 +5559,9 @@ def seekable(self):
def test_split_on_trailing_comma() -> None:
- test_input = "from lib import (a, b, c,)"
+ test_input = "from lib import (a as b,)"
expected_output = """from lib import (
- a,
- b,
- c,
+ a as b,
)
"""
EDIT: indeed, that reproduces on 8cde8b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2338