Fix 403 Error Page Aesthetics #592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundobatista
requested changes
Dec 24, 2024
eduzen
requested changes
Jan 4, 2025
joboffers/views.py
Outdated
| @@ -399,7 +401,7 @@ def get_queryset(self): | |||
| queryset = super().get_queryset() | |||
| search = self.request.GET.get('search') | |||
|
|
|||
| if search: | |||
| if (search): | |||
There was a problem hiding this comment.
Hello @eduzen,
I’ve reviewed your feedback and reverted the unnecessary changes in the PR. The updates now focus solely on fixing the issue with the 403 error page aesthetics.
Please let me know if there’s anything else that needs adjustment or improvement. I appreciate your guidance and time
Thank you!
joboffers/tests/test_models.py
Outdated
| joboffer_url = reverse('joboffers:view', kwargs={'slug': dummy_job_slug}) | ||
| expected_url = "".join(('https://example.com', joboffer_url)) | ||
|
|
||
| joboffer = JobOffer(slug=dummy_job_slug) | ||
| result = joboffer.get_full_url() | ||
| assert expected_url == result | ||
|
|
||
| assert result == expected_url |
There was a problem hiding this comment.
All these changes does not add any value...
JigyasuRajput
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cambios propuestos:
Temas tratados:
Pruebas realizadas:
Cómo probar los cambios:
Gracias por contribuir con el proyecto.
Estamos pendiente de revisar los cambios propuestos.