Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Charges are not spent #151

Open
LupusVentus opened this issue May 31, 2024 · 4 comments
Open

[BUG] Charges are not spent #151

LupusVentus opened this issue May 31, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@LupusVentus
Copy link

Module Version: v4.1.5.1
System Version: DnD 3.2.0
Foundry Version: 11.315
Midi 11.4.32

Before open any issue
No distinct message appears in the console

Describe the bug
No charges of a magic item are spent if using a single target action, while having a targeted token beforehand.

To Reproduce
Steps to reproduce the behavior:

  1. Create a magic item
  2. Add a single target action that uses charges (i.e. ranged attack)
  3. Target any creature and use the action
  4. See how action gets processed, but no charges get spent
@LupusVentus LupusVentus added the bug Something isn't working label May 31, 2024
@PwQt PwQt self-assigned this May 31, 2024
@PwQt PwQt added this to the 4.1.6 milestone Jun 1, 2024
@PwQt
Copy link
Owner

PwQt commented Jun 22, 2024

@LupusVentus do you mean charges you've set up in Item or in "Magic Item" tab in the item?

@nschoenwald
Copy link

@LupusVentus do you mean charges you've set up in Item or in "Magic Item" tab in the item?

Not the original creator of the issue, but I think the expected behavior should be that charges on the item are synced with the "Magic item" charges or that the module just uses the charges on the item, there's no reason for two different values from a user perspective.

@nschoenwald
Copy link

If I understand correctly, this is the same issue: #131

@PwQt
Copy link
Owner

PwQt commented Jun 22, 2024

Yes, I'm planning as a next major "upgrade" to do an interim period of having a choice of "internal" charges with the current system, and it'll gradually be phased out of.

@PwQt PwQt modified the milestones: 4.1.6, 5.0.0 Jun 22, 2024
@PwQt PwQt removed this from the 5.0.0 milestone Sep 14, 2024
@PwQt PwQt added this to the 4.3.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants