[BUG] Spells added to items temporarily filtered out when Prepared filter is activated (restored on closing and reopening sheet)

[TremendoDude]

Module Version: v1.7.2

Console message
No console errors.

Describe the bug
Because the default Spell Preparation mode for most compendium spells is set to Prepared with the checkbox unchecked, spells added to Magic Items will be filtered out when using the Filter to filter out unprepared spells. This is undesirable behavior, as Magic Items almost never have a spell preparation system, classes whose spell lists are filled to the brim with unprepared spells will be unable to use the Filter to view all of their currently available spells without inadvertently hiding Magic Item spells as well, and the module's system of only referencing abilities from the Items tab or Compendiums instead of adding a unique instance prevents the user from editing the spell to check the Prepared box to circumvent the issue.

However, this undesirable behavior seems to only be a temporary hiccup, as closing and reopening the Character Sheet will keep the Prepared filter on but with the Magic Item spells now completely visible.

To Reproduce

1. Add any SRD spell to a Magic Item.
   The spell will appear at the bottom of the character's Spells tab.
2. On the character's Spells tab, use the Filter to filter for Prepared (aka available) spells.
   Magic Item spells will be hidden away (despite not needing to be prepared to use).
3. Close and reopen the character sheet.
   The Filter should still be active, but Magic Item spells are now visible and accessible.

Expected behavior
The spells either should not be affected by the Prepared filter. Perhaps the Prepared checkbox should be considered checked by default to avoid the spell being filtered out.

Browser:
Built-in Foundry

Foundry Version:
v11 Stable Build 315

Game System:
D&D5e v3.1.0

[leojackson]

I see similar behavior as well in the most recent version of Magic Items. I wanted to add a few additional notes, as it appears all of the filters for spells are impacted by this bug, not only the Prepared filter.

1. If the Prepared filter is removed before closing and re-opening the character sheet, only one spell is shown for each item, even if the item has multiple spells.

   Before applying Prepared filter, all spells shown on all items:
   

   After applying Prepared filter, no spells shown on any items:
   

   After removing Prepared filter, only one spell shown for each item:
   

2. While marking the spell as Prepared or changing it to Always Prepared would modify the underlying item and therefore would not be a viable alternative, I confirmed that even doing this has no impact on the behavior. With spells marked as Always Available or with the Prepared checkbox checked, the spells are still filtered out by the Prepared spell filter.

3. The same behavior observed on the Prepared filter is also observed on the Bonus Action, Reaction, Concentration, and Ritual filters, as well as all of the magic school filters - Abjuration, Conjuration, etc. All spells are filtered out, whether they should match the filter or not. Only the last spell in the list on each magic item is added back when the filter is removed.

4. The Action filter will show only the last spell in the list for each magic item, whether that spell uses an Action or not. Removing the Action filter has no effect.

Module Version:
4.0.0

Browser:
Chrome & Edge

Foundry Version:
v11 Stable Build 315

Game System:
D&D5e v3.1.0

[PwQt]

D&D5e v3.1.0

It might be due to this, 4.1 will disable support for 3.1 but I'll investigate further, it might be due to MI not necessarily being the same thing as a proper spell

[PwQt]

I am currently on D&D5e 3.1.x, I will check that.