Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow using offline player #453

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: allow using offline player #453

wants to merge 3 commits into from
+1,083 −427

Conversation

smuu
Copy link
Contributor

@smuu smuu commented Jan 4, 2025 •
edited
Loading

Description

  • You will be able to address an offline player (for example, for op and whitelist)
  • With player.is_online(), you can check if a fetched player is online
  • If the player is not online, fields that only an online player has, is an empty Option
  • Main file to review is: pumpkin/src/entity/player.rs
  • I was considering different approaches but ended up with this one
  • Happy to discuss the design I decided on

Closes #438

Testing

Please follow our Coding Guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be able to address users who are offline
1 participant
@smuu