Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrument/touch/top middle bottom calculation #10

Open
aburt2 opened this issue Aug 1, 2024 · 5 comments
Open

instrument/touch/top middle bottom calculation #10

aburt2 opened this issue Aug 1, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@aburt2
Copy link
Contributor

aburt2 commented Aug 1, 2024

5G T-Sticks now have 30 touch sensors compared to 16 previously.
Top and bottom areas still seem to correspond to 4 touch sensors (legacy of previous generations). Which means middle section contains 22 sensors!

There should a discussion to decide how the 3 sections should be split and update the firmware accordingly. Older T-Sticks were 4-8-4 (25%-50%-25%).
7-16-7 and 8-14-8 would be closest to existing T-Sticks. Or do we want to go 10-10-10?

@Gael514

@aburt2
Copy link
Contributor Author

aburt2 commented Aug 1, 2024

@edumeneses I can probably do this quickly over the weekend, the touchsizeedge variable should be computed based on the touchsize rather then arbitrary,

Alternatively I can just move touchsizeedge as a public property and just change it in T-Stick code.

@aburt2
Copy link
Contributor Author

aburt2 commented Aug 1, 2024

It would be nicer to define it in terms of percentage to make it easier for others tochange the threshold themselves

@edumeneses
Copy link
Member

Thank you for pinging me again, this issue slipped through the cracks.

We will work on that directly on the refactoring.

Pinging @rochanaf for reference

@aburt2
Copy link
Contributor Author

aburt2 commented Aug 1, 2024

I'll do a quick fix, just for the folks at IDMIL so the touch behaviour scales with the size of the T-Stick I'll leave more thorough solutions for the refractoring

@edumeneses
Copy link
Member

I will tag this as an enhancement to be added after #16

@edumeneses edumeneses added the enhancement New feature or request label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants