Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplayer packet names need to be consistent in documentation and in TSAPI/TShock #1572

Open
hakusaro opened this issue Dec 20, 2017 · 1 comment

Comments

@hakusaro
Copy link
Member

Currently, the multiplayer packet docs refer to packets by names that don't match those in the PacketTypes enum and subsequent naming convention for packets. This is problematic as it makes referring to the packet documentation confusing because you have to go through PacketTypes to get the packet number, and then jump to the docs by number.

Preferably, the names in TShock should match those on the multiplayer packet documentation page.

@bartico6
Copy link
Member

I also think their names should be rephrased and cleaned up eventually (with old names left in as obsolete entries of the enum).
Example is Pryaxis/TSAPI#159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants