Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It'd be great to have a gosop compiled with x/crypto/openpgp #27

Open
teythoon opened this issue Mar 27, 2024 · 2 comments
Open

It'd be great to have a gosop compiled with x/crypto/openpgp #27

teythoon opened this issue Mar 27, 2024 · 2 comments

Comments

@teythoon
Copy link

I don't know how much the API diverged, and how much work that would be. If we had a gosop to test x/crypto/openpgp with, we could put it into the test suite. Maybe that'd even encourage some users to switch to GopenPGP.

@twiss
Copy link
Member

twiss commented Mar 27, 2024

It'd essentially entail a rewrite (except for the CLI part, of course). Note that GopenPGP is a wrapper around ProtonMail/go-crypto, which is in turn derived from x/crypto/openpgp - so GopenPGP itself shares no API with x/crypto. GopenPGP also provides a much more high-level API than {x/,ProtonMail/go-}crypto, so a SOP implementation using the latter would need to reimplement a bunch of logic from GopenPGP.

It might be easier to build a version of GopenPGP (v2) that uses x/crypto/openpgp. That should not be too much work since ProtonMail/go-crypto is largely backwards compatible with it, though x/crypto/openpgp might be missing some things that GopenPGP uses - but I'm not sure if those parts are critical to the functionality needed by SOP; that might be worth investigating.

@teythoon
Copy link
Author

teythoon commented Apr 2, 2024

Thanks for providing the details. I cannot judge how much work that is and what the benefit might be, really, so feel free to close the issue, your call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants