From 50905374116d290728524a33ee5fa1c7f0269216 Mon Sep 17 00:00:00 2001 From: Carlos Alexandro Becker Date: Thu, 16 Jan 2025 09:50:55 -0300 Subject: [PATCH] fix: make issuerKeyID non-critical again closes https://github.com/ProtonMail/go-crypto/issues/263 --- openpgp/packet/signature.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/openpgp/packet/signature.go b/openpgp/packet/signature.go index 3a4b366d8..979c5d775 100644 --- a/openpgp/packet/signature.go +++ b/openpgp/packet/signature.go @@ -1288,7 +1288,9 @@ func (sig *Signature) buildSubpackets(issuer PublicKey) (subpackets []outputSubp if sig.IssuerKeyId != nil && sig.Version == 4 { keyId := make([]byte, 8) binary.BigEndian.PutUint64(keyId, *sig.IssuerKeyId) - subpackets = append(subpackets, outputSubpacket{true, issuerSubpacket, true, keyId}) + // XXX: making this critical breaks RPM <=4.16. + // See: https://github.com/ProtonMail/go-crypto/issues/263 + subpackets = append(subpackets, outputSubpacket{true, issuerSubpacket, false, keyId}) } // Notation Data for _, notation := range sig.Notations {