Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerifyRevocationSignature is misnamed #189

Closed
andrewgdotcom opened this issue Nov 23, 2023 · 2 comments
Closed

VerifyRevocationSignature is misnamed #189

andrewgdotcom opened this issue Nov 23, 2023 · 2 comments

Comments

@andrewgdotcom
Copy link
Contributor

andrewgdotcom commented Nov 23, 2023

(PublicKey)VerifyRevocationSignature appears also to be able to verify any direct signature. Is this intentional? And can I rely on it always working for direct certifications? :-)

@andrewgdotcom andrewgdotcom changed the title VerifyRevocationSignature is misname VerifyRevocationSignature is misnamed Nov 23, 2023
@lubux
Copy link
Contributor

lubux commented Nov 24, 2023

Hi, good question. Yes, it should work since direct-key signatures are computed on the same hash of the key to be signed, and the signature types are not checked.
The next update of the go-crypto library includes a dedicated function to verify direct-key signatures although the logic is the same.

@andrewgdotcom
Copy link
Contributor Author

Thanks, that's what it looked like from the code but I wanted to make sure it wouldn't unexpectedly break at some point in the future if I relied upon it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants