Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adhere to system theme. #384

Closed
1 of 3 tasks
RokeJulianLockhart opened this issue Mar 21, 2024 · 5 comments
Closed
1 of 3 tasks

Adhere to system theme. #384

RokeJulianLockhart opened this issue Mar 21, 2024 · 5 comments

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Mar 21, 2024 •
edited
Loading

Prerequisites

  1. I have searched open and closed issues for duplicates
  2. This isn't a feature request
  3. This is not a report about my app not working as expected

Issue

Like ProtonMail/proton-mail#71 (comment) describes, Proton Mail should switch themes depending upon the system-reported theme. https://protonmail.uservoice.com/forums/284483-proton-mail/suggestions/43402152-use-system-setting-for-light-dark-mode requests this, and has been erroneously closed as implemented.
@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Mar 21, 2024 •
edited
Loading

#384 (comment)

Amazingly, I just... didn't see the feature at https://account.proton.me/u/1/mail/appearance#theme. 6 times. I suppose the human brain just shows what it wants to, sometimes.

@avidseeker
Copy link

This might be a regression. Protonmail doesn't detect system theme on Chromium.

  • Chromium > Settings > Dark theme
  • Check for Sec-CH-Prefers-Color-Scheme: dark http header in https://deviceinfo.me
  • Protonmail > Settings > Theme > Sync with system
  • Expected: display site in dark theme
  • Result: site displayed in light theme

@RokeJulianLockhart

This comment was marked as resolved.

Sign in to view
@RokeJulianLockhart

This comment was marked as duplicate.

Sign in to view
@RokeJulianLockhart RokeJulianLockhart closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2024
@RokeJulianLockhart
Copy link
Author

#384 (comment)

Ah, located it: #396 (comment). Apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RokeJulianLockhart @avidseeker