-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for ipython notebooks #81
Comments
Yep, I'm on it now. |
Fixing the imports was not enough, there's a deeper problem somewhere in the call to energy_objective. I'll continue to look at this. |
👍 |
OK, I have a fix. The problem was pretty subtle and is not related to my changes, though in retrospect I should've thought of it earlier. I'll send a PR soon. |
Thanks. @damiansteiger are these tests for the demo ipython notebook (just something to make sure the notebook can run without errors) something you can help us with in the next couple weeks? It is really bad that we keep breaking the demo and I frankly don't really know how to write such tests myself. You had once mentioned to me that it could be done. |
We've had a few problems with people submitting pull requests that break the demo file. The demo is quite important because it is likely the first thing that new users will read. However, we currently have no method to test whether it runs without errors. Such a test would save us a lot of trouble!
The text was updated successfully, but these errors were encountered: