Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for ipython notebooks #81

Open
babbush opened this issue Jun 23, 2017 · 7 comments
Open

Tests for ipython notebooks #81

babbush opened this issue Jun 23, 2017 · 7 comments
Assignees

Comments

@babbush
Copy link
Contributor

babbush commented Jun 23, 2017

We've had a few problems with people submitting pull requests that break the demo file. The demo is quite important because it is likely the first thing that new users will read. However, we currently have no method to test whether it runs without errors. Such a test would save us a lot of trouble!

@babbush
Copy link
Contributor Author

babbush commented Aug 9, 2017

To illustrate the importance of this: I think @idk3 recent changes which moved the UCC code into the circuits folder (which I merged) may have broken the demo. @idk3 can you please fix the demo? I think getting tests for the demo in place should really be a priority.

@idk3
Copy link
Collaborator

idk3 commented Aug 9, 2017

Yep, I'm on it now.

@idk3
Copy link
Collaborator

idk3 commented Aug 9, 2017

Fixing the imports was not enough, there's a deeper problem somewhere in the call to energy_objective. I'll continue to look at this.

@babbush
Copy link
Contributor Author

babbush commented Aug 9, 2017

👍

@idk3
Copy link
Collaborator

idk3 commented Aug 9, 2017

OK, I have a fix. The problem was pretty subtle and is not related to my changes, though in retrospect I should've thought of it earlier. I'll send a PR soon.

@idk3
Copy link
Collaborator

idk3 commented Aug 9, 2017

#138

@babbush
Copy link
Contributor Author

babbush commented Aug 10, 2017

Thanks. @damiansteiger are these tests for the demo ipython notebook (just something to make sure the notebook can run without errors) something you can help us with in the next couple weeks? It is really bad that we keep breaking the demo and I frankly don't really know how to write such tests myself. You had once mentioned to me that it could be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants