Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin link checker to Python < 3.13 to keep it running (for now) #126

Open
brian-rose opened this issue Oct 11, 2024 · 5 comments · Fixed by #127 or #128
Open

Pin link checker to Python < 3.13 to keep it running (for now) #126

brian-rose opened this issue Oct 11, 2024 · 5 comments · Fixed by #127 or #128
Labels
bug Issues that present a reasonable conviction there is a reproducible bug. infrastructure Infrastructure related issue

Comments

@brian-rose
Copy link
Member

Currently all link-checker runs are failing at run time with

Extension error:
Could not import extension sphinx.builders.epub3 (exception: No module named 'imghdr')
Traceback (most recent call last):
  File "/home/runner/miniconda3/envs/test/lib/python3.13/site-packages/sphinx/registry.py", line 459, in load_extension
    mod = import_module(extname)
  File "/home/runner/miniconda3/envs/test/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Appears to be something broken in the Sphinx ecosystem.

@brian-rose brian-rose added the infrastructure Infrastructure related issue label Oct 11, 2024
@brian-rose
Copy link
Member Author

I was able to reproduce the same error locally on the Cookbook Template repo with

conda create --name testlink jupyter-book -c conda-forge
conda activate testlink
jupyter-book build --builder linkcheck .

I wonder if this is related to the fact that conda-forge is now installing Python 3.13 by default.

@brian-rose
Copy link
Member Author

Suspicion confirmed. When I did this, the link-checker worked normally:

conda create --name testlink-py12 jupyter-book python=3.12 -c conda-forge
conda activate testlink-py12
jupyter-book build --builder linkcheck .

Something upstream in JupyterBook / sphinx must be incompatible with Python 3.13. Would be worth digging a little to see if this has been flagged in the right places yet.

@brian-rose brian-rose added the bug Issues that present a reasonable conviction there is a reproducible bug. label Oct 11, 2024
@brian-rose
Copy link
Member Author

The quick fix would be to just add

python<3.13

to this line

But it would be best to track the issue properly so we can remove that version pin once it's resolved.

@brian-rose brian-rose changed the title Link checker is broken -- all nightly builds are failing Pin link checker to Python < 3.13 to keep it running (for now) Oct 15, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Pythia Projects Board Oct 15, 2024
@brian-rose brian-rose reopened this Oct 15, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Pythia Projects Board Oct 15, 2024
@brian-rose
Copy link
Member Author

@github-project-automation github-project-automation bot moved this from In Progress to Done in Pythia Projects Board Oct 16, 2024
@brian-rose brian-rose reopened this Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Pythia Projects Board Oct 16, 2024
@brian-rose
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that present a reasonable conviction there is a reproducible bug. infrastructure Infrastructure related issue
Projects
Status: In Progress
1 participant