-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Add new notebook calculating ENSO with intake-esgf #65
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
Nice! I'll take a look at this today. It seems like the preview action is failing because the environment is not being updated to include |
This is a current limitation of our build actions (ProjectPythia/cookbook-actions#77). This "edge case" of building on Binder with secrets and a change in the environment file is not something we currently handle. There are complications around the scope rules for using secrets that we haven't solved. The workaround is as Rob says: open a simple PR just adding the new package to the environment file and merge it into main even though it won't build and preview properly. Then proceed with this PR. |
@brian-rose @r-ford - I submitted a PR with the suggested way forward 😄 |
@brian-rose - unpinning numpy here brought back the numba issues... I will submit a PR to revert the numpy version. |
@brian-rose @r-ford numba is causing issues with the main execution environment. The opendap issue has been resolved, I am not sure what to do about rebuilding the conda environment for the book here. Those recent PRs did not trigger a reinstallation of numba. |
Show how to use intake-esgf to access data, apply ENSO calculations, and visualize using hvPlot.