From b5976a6bf06cdf7c96e1aa518bb57dbe57975123 Mon Sep 17 00:00:00 2001 From: MrDeadCe11 Date: Fri, 21 Jun 2024 03:04:38 -0500 Subject: [PATCH 1/2] updated substandard 5 --- SIPS/sip-15.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/SIPS/sip-15.md b/SIPS/sip-15.md index 60ac4b5..3d4002f 100644 --- a/SIPS/sip-15.md +++ b/SIPS/sip-15.md @@ -57,14 +57,14 @@ todo MUST be compact Initial substandards include: -| substandard ID | description | decoding scheme | -| -------------- | ------------------------------------------------------------------------------------------------------------ | ------------------------------------------------------------------------------- | -| 0 | first consideration item, comparison "equal to", single trait key, zero trait value | `(bytes32 traitKey)` TODO think about this should be in the zone hash, when no extra data is provided | -| 1 | token address and id from first offer item | `(uint8 comparisonEnum, bytes32 traitValue, bytes32 traitKey)` | -| 2 | token address and id from the first consideration item | `(uint8 comparisonEnum, bytes32 traitValue, bytes32 traitKey)` | -| 3 | single token id, single trait key and value(single) | `(uint8 comparisonEnum, address token, uint256 tokenId, bytes32 traitValue, bytes32 traitKey)` | -| 4 | multiple token ids, single trait key and value(multiple) | `(uint8 comparisonEnum, address token, uint256 tokenId, bytes32 traitValue, bytes32 traitKey)[]` | -| 5 | single token id, multiple traitKeys and values | `` | +| substandard ID | description | decoding scheme | +| -------------- | ----------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------ | +| 0 | first consideration item, comparison "equal to", single trait key, zero trait value | `(bytes32 traitKey)` TODO think about this should be in the zone hash, when no extra data is provided | +| 1 | token address and id from first offer item | `(uint8 comparisonEnum, bytes32 traitValue, bytes32 traitKey)` | +| 2 | token address and id from the first consideration item | `(uint8 comparisonEnum, bytes32 traitValue, bytes32 traitKey)` | +| 3 | single token id, single trait key and value(single) | `(uint8 comparisonEnum, address token, uint256 tokenId, bytes32 traitValue, bytes32 traitKey)` | +| 4 | multiple token ids, single trait key and value(multiple) | `(uint8 comparisonEnum, address token, traits, uint256 tokenId, bytes32 traitValue, bytes32 traitKey)[]` | +| 5 | single token id, optional traits address, multiple traitKeys and values | `ComparisonStruct(uint8[] comparisonEnums, address token, address traits, uint256 identifier, bytes32[] traitValues, bytes32[] traitKeys)` | | comparison enum | behavior | | --------------- | ------------------------ | From c1a1ceeaa43d8a3dfbef02b7bfcfa4337262b534 Mon Sep 17 00:00:00 2001 From: Patrick Gallagher Date: Fri, 21 Jun 2024 13:21:01 -0500 Subject: [PATCH 2/2] Update sip-15.md --- SIPS/sip-15.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SIPS/sip-15.md b/SIPS/sip-15.md index 3d4002f..00eba04 100644 --- a/SIPS/sip-15.md +++ b/SIPS/sip-15.md @@ -63,7 +63,7 @@ Initial substandards include: | 1 | token address and id from first offer item | `(uint8 comparisonEnum, bytes32 traitValue, bytes32 traitKey)` | | 2 | token address and id from the first consideration item | `(uint8 comparisonEnum, bytes32 traitValue, bytes32 traitKey)` | | 3 | single token id, single trait key and value(single) | `(uint8 comparisonEnum, address token, uint256 tokenId, bytes32 traitValue, bytes32 traitKey)` | -| 4 | multiple token ids, single trait key and value(multiple) | `(uint8 comparisonEnum, address token, traits, uint256 tokenId, bytes32 traitValue, bytes32 traitKey)[]` | +| 4 | multiple token ids, single trait key and value(multiple) | `(uint8 comparisonEnum, address token, uint256 tokenId, bytes32 traitValue, bytes32 traitKey)[]` | | 5 | single token id, optional traits address, multiple traitKeys and values | `ComparisonStruct(uint8[] comparisonEnums, address token, address traits, uint256 identifier, bytes32[] traitValues, bytes32[] traitKeys)` | | comparison enum | behavior |