Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect Error #40

Closed
covyy opened this issue Sep 26, 2024 · 5 comments
Closed

Disconnect Error #40

covyy opened this issue Sep 26, 2024 · 5 comments

Comments

@covyy
Copy link

covyy commented Sep 26, 2024

I used the example code from the repo.

Connecting to the proxy kicks the client with a "Disconnect" error.

This is because the minecraft-protocol module is not up to date, which uses a deprecated method in
node_modules/minecraft-protocol/src/server/login.js
at
const decryptedToken = crypto.privateDecrypt({...
which throws the following error:
Error during decryption: TypeError: RSA_PKCS1_PADDING is no longer supported for private decryption, this can be reverted with --security-revert=CVE-2023-46809

@covyy
Copy link
Author

covyy commented Dec 24, 2024

Turns out it's not directly due to the minecraft-protcol version but rather the node version and minecraft-protcol doesnt support the latest yet. A fix for this was implemented here:
https://github.com/PrismarineJS/node-minecraft-protocol/pull/1319/files#submit-review
with this duplicate issue:
PrismarineJS/node-minecraft-protocol#1289

I will mark this as closed as this will need to be fixed in minecraft-protocol

@covyy covyy closed this as completed Dec 24, 2024
@extremeheat
Copy link
Member

@covyy can you confirm PrismarineJS/node-minecraft-protocol#1319 works? It's been blocked waiting for someone to test.

@covyy
Copy link
Author

covyy commented Dec 24, 2024

Approved it but I don't have write access so I think its still blocked no?

@extremeheat
Copy link
Member

Have you actually tested it to work in-game?

@covyy
Copy link
Author

covyy commented Dec 24, 2024

Yes, works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants