Add getItemEnchantmentLevel() function, to easily see if an item has an enchantment and at what level.

[zisis912]

title

[extremeheat]

This seems unnecessary when you can do this in one line already with .find

item.enchants.find(e => e.name === 'efficiency')?.level

[extremeheat]

In this case item.enchants likely would have been better as a dictionary (since enchant.name is a unique key), but not a big deal.

You can get a dict yourself with Object.fromEntries(item.enchants.map(e => [e.name, e]))

[extremeheat]

Ah, one thing I did realize with the current implementation is that it has a enchants setter (these are bad), so to edit the enchants, you have to

const enchants = item.enchants
enchants.find(ench => enc.name === 'efficiency').level = 3
item.enchants = enchants

IMO all the get/set inside prismarine-item should be removed for non-obvious usage patterns like this. item.enchants returns a mutation, so you need to store to a variable else simply editing the object and trying to trigger the setter again will simply edit a GC'ed item.

[zisis912]

I made this commit because I am translating large parts of the java source code to mineflayer to implement more clicking tyoes, so having identically named functions is a big help.

Also in my opinion both setters and getters should not be a thing, they are both stupid and serve no purpose. I would choose getEnchants() and setEnchants any day

[rom1504]

enchants should be a dict if you want that

[rom1504]

can you update the doc

[rom1504]

old, please re open to finish