Tests failing. Not entirely sure how this test suite could ever succeed?

Test are failing due to the default clientId:

No longer being a valid client thus causing the test for fetching deviceCode to fail.

Honestly I'm not sure of the benefit of keeping msal as our default flow, we might as well default to live and set authTitle to Minecraft Nintendo. msal is only really needed if using a custom azure app.

Yeah, it can be changed to default to live. Although we have to default to a Minecraft bedrock token which may not be appropriate for all users, more importantly we want to keep auth API working without breaking auth workflows for downstream users. Will be done with #97

Can you rebase on master?

Rebased

Would be great to know when this changed. Can anyone test to make sure it works?

We run with this endpoint at https://minecraftafk.com (managing thousands of accounts). We have no reported auth issues since making the update.

From a quick check of node-minecraft-protocol we also don't actually verify anything inside entitlements, but only use it for logging debug information. Assuming nothing else big is using it I think we can make this change with a note in the API changelog without breaking anything.

The linked issues PrismarineJS/mineflayer#3286 and PrismarineJS/mineflayer#2890 have to do with the /profile endpoint so any changes to the Minecraft java entitlements endpoint here would be unrelated to them. Do you think the PR is still separately valid?

The linked issues PrismarineJS/mineflayer#3286 and PrismarineJS/mineflayer#2890 have to do with the /profile endpoint so any changes to the Minecraft java entitlements endpoint here would be unrelated to them. Do you think the PR is still separately valid?

That's a reasonable assumption but actually incorrect. When refreshing tokens for Xbox Game Pass accounts (and likely other newer accounts) without fetching entitlements, the profile endpoint will return no data. As soon as you make the entitlements request, the profile endpoint is populated. Mojang at their best.

They do not return the same data so this could be a breaking change, what do we do about that and do you know why one endpoint would work and not the other?

I guess the old endpoint is preserved for backwards compatibility (why?). As (kind of) mentioned above the current endpoint only seems to cause issues when trying to refresh the token of a newer account (my assumption is post-migration).

Can you update the types?

Finished in #101, thanks