Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing cookie and tranfser packets in protocol specification #939

Open
BigVirusBoi opened this issue Nov 12, 2024 · 6 comments
Open

Missing cookie and tranfser packets in protocol specification #939

BigVirusBoi opened this issue Nov 12, 2024 · 6 comments

Comments

@BigVirusBoi
Copy link

BigVirusBoi commented Nov 12, 2024

It seems like the transfer and cookie packets are missing from minecraft-data. https://prismarinejs.github.io/minecraft-data/?v=1.20.5&d=protocol. They should appear from version 1.20.5 to latest, but are not present.

@GroobleDierne
Copy link
Contributor

I think they were added after 1.20.5

@BigVirusBoi
Copy link
Author

BigVirusBoi commented Nov 12, 2024

According to wiki.vg, the cookie packets (and transfer packet) exist in 1.20.5 (protocol version 766) up to the latest version (1.21.3). I found this article on Minecraft's website where they say a new "transfer" packet and "cookie" packet has been added. I can also confirm that the packets in question do not appear in minecraft-data on versions 1.20.5, 1.20.6 and 1.21.1. :)

@GroobleDierne
Copy link
Contributor

According to wiki.vg, the cookie packets (and transfer packet) exist in 1.20.5 (protocol version 766) up to the latest version (1.21.3). I found this article on Minecraft's website where they say a new "transfer" packet and "cookie" packet has been added. I can also confirm that the packets in question do not appear in minecraft-data on versions 1.20.5, 1.20.6 and 1.21.1. :)

I just checked and cookie packets are present in mc-data for those versions they are called cookie_request & cookie_response and the transfer packet is... well transfer.
https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.20.5/protocol.json#L7602
https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.20.5/protocol.json#L8887
https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.20.5/protocol.json#L7695

@BigVirusBoi
Copy link
Author

BigVirusBoi commented Nov 28, 2024

I just checked and cookie packets are present in mc-data for those versions they are called cookie_request & cookie_response and the transfer packet is... well transfer. https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.20.5/protocol.json#L7602 https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.20.5/protocol.json#L8887 https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.20.5/protocol.json#L7695

Oh. That is weird. I am unable to see those packets in the GitHub Pages thing. Are you able to see the cookie packets in https://prismarinejs.github.io/minecraft-data/?v=1.20.5&d=protocol (and later)?

(Sorry to bother you about this)

@GroobleDierne
Copy link
Contributor

The cookie and transfer packets are common packets which means they are present in multiple phases of the protocol, I guess the site doesn't handle them properly because of that.

@BigVirusBoi
Copy link
Author

Ohh. That makes sense. Thanks for the help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants