Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ps_crossselling: Does not take into account the shop in which the orders were placed #29136

Open
2 tasks done
lmeyer1 opened this issue Jul 22, 2022 · 6 comments · May be fixed by PrestaShop/ps_crossselling#39
Open
2 tasks done

ps_crossselling: Does not take into account the shop in which the orders were placed #29136

lmeyer1 opened this issue Jul 22, 2022 · 6 comments · May be fixed by PrestaShop/ps_crossselling#39
Labels
1.7.6.5 Affects versions BO Category: Back Office Bug Type: Bug Cross selling Module: ps_crossselling Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Module Module Order Component: Which BO section is concerned Verified The issue has been reproduced

Comments

@lmeyer1
Copy link
Contributor

lmeyer1 commented Jul 22, 2022

Prerequisites

Describe the bug and add screenshots

In multishop configuration, the algorithm to search for orders does not take into account the shop where the order was placed.

Suppose:

  • in shop 1 product A was bought together with product B
  • in shop 2 product A was bought together with product C

Observation:
In both shops, the module will display products B and C as bought together with product A

Expected behavior

The result should be contextualized to the shop:

  • in shop 1 the module should display product B
  • in shop 2 the module should display product C

This might be a minor issue if the two shops have the same owner. But in general, this module should take into account current shop

Steps to reproduce

Setup the products and the orders in the two shops as explained above:

Suppose:

  • in shop 1 product A was bought together with product B
  • in shop 2 product A was bought together with product C

Observation:
In both shops, the module will display products B and C as bought together with product A

PrestaShop version(s) where the bug happened

1.7.8.6

PHP version(s) where the bug happened

7.3

If your bug is related to a module, specify its name and its version

ps_crossselling 2.0.1
@lmeyer1 lmeyer1 added Bug Type: Bug New New issue not yet processed by QA labels Jul 22, 2022
@lmeyer1 lmeyer1 linked a pull request Jul 22, 2022 that will close this issue
Open
@AureRita
Copy link
Contributor

AureRita commented Jul 25, 2022 •
edited
Loading

Hi @lmeyer1

Thank you for your report, I find that this issue is maybe a dupplicate of this one : #16790. What do you think about it ?

Thank you for your PR 🚀

Waiting for your feedback

@AureRita AureRita added Waiting for author Status: action required, waiting for author feedback BO Category: Back Office NMI Status: issue needs more information Order Component: Which BO section is concerned Cross selling Module: ps_crossselling Module Module 1.7.8.6 Affects versions and removed New New issue not yet processed by QA labels Jul 25, 2022
@lmeyer1
Copy link
Contributor Author

lmeyer1 commented Jul 26, 2022

@AureRita Certainly you didn't post the correct link. #16790 is completely unrelated and about order states.

@prestashop-issue-bot prestashop-issue-bot bot removed the Waiting for author Status: action required, waiting for author feedback label Jul 26, 2022
@AureRita
Copy link
Contributor

Hi @lmeyer1 ,

Yes, Indeed, I confused order status with order states, sorry,

So, I reproduce your issue with PrestaShop version 1.7.6.5/1.7.8.6 , I'll add this to the backlog

Thank you for the reporting and the PR

@AureRita AureRita added Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Needs Specs Status: issue needs to be specified 1.7.6.5 Affects versions Verified The issue has been reproduced and removed NMI Status: issue needs more information 1.7.8.6 Affects versions labels Jul 26, 2022
@prestashop-issue-bot prestashop-issue-bot bot removed the Needs Specs Status: issue needs to be specified label Dec 5, 2022
@MhiriFaten MhiriFaten reopened this Dec 5, 2022
@MhiriFaten
Copy link

Hello @lmeyer1

I didn't reproduce the issue
Here is a screen record

Untitled_.Dec.5.2022.4_15.PM.webm

Did I miss something?
Waiting for your feedback.

@lmeyer1
Copy link
Contributor Author

lmeyer1 commented Dec 6, 2022

Hello @MhiriFaten ,
Your screen record is missing the most important part: It does not show the product details with the crossselling module in action after passing the orders.
Why did you try to reproduce it again? @AureRita did it successfully before.

@MhiriFaten
Copy link

Thank you @lmeyer1 for your feedback,

I tried to reproduce it again because I have to test the issue without PR since I am testing the PR.
I will check it with @AureRita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.7.6.5 Affects versions BO Category: Back Office Bug Type: Bug Cross selling Module: ps_crossselling Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Module Module Order Component: Which BO section is concerned Verified The issue has been reproduced
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix orders by shop lmeyer1/ps_crossselling
3 participants
@lmeyer1 @AureRita @MhiriFaten