From ac3f46d72faae19dc34425c6add2a58087a582eb Mon Sep 17 00:00:00 2001 From: Jonathan LELIEVRE Date: Fri, 29 Nov 2024 08:32:14 +0100 Subject: [PATCH 1/2] Add nullable type for PHP 8.4 compatibility --- src/PHPSQLParser/processors/AbstractProcessor.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PHPSQLParser/processors/AbstractProcessor.php b/src/PHPSQLParser/processors/AbstractProcessor.php index b172399d..29b2add9 100644 --- a/src/PHPSQLParser/processors/AbstractProcessor.php +++ b/src/PHPSQLParser/processors/AbstractProcessor.php @@ -62,9 +62,9 @@ abstract class AbstractProcessor { /** * AbstractProcessor constructor. * - * @param Options $options + * @param Options|null $options */ - public function __construct(Options $options = null) + public function __construct(?Options $options = null) { $this->options = $options; } From 471591c7472376708a7a45e080b2af1396383696 Mon Sep 17 00:00:00 2001 From: Jonathan LELIEVRE Date: Fri, 29 Nov 2024 08:32:54 +0100 Subject: [PATCH 2/2] Add PHP 8.4 in the CI --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b0822cd2..f3cf7eff 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,6 +1,6 @@ name: CI -on: [push] +on: [push, pull_request] jobs: build-test: @@ -16,6 +16,7 @@ jobs: - 7.4 - 8.2 - 8.3 + - 8.4 - nightly steps: @@ -38,4 +39,4 @@ jobs: uses: actions/upload-artifact@v3 with: name: code-coverage-report - path: coverage/html \ No newline at end of file + path: coverage/html