Enhancement: Add visual queue to p-selection options dropdown when there is overflow #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleek91
requested review from
znicholasbrown,
zhen0 and
brandonreid
as code owners
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
znicholasbrown
approved these changes
May 22, 2023
There was a problem hiding this comment.
I like this as a compromise - curious for @brandonreid's thoughts
brandonreid
approved these changes
May 23, 2023
|
I created a separate issue around keyboard interaction, keeping the highlight visible. Could see making a highlighted option have a higher z-index than the shadow somehow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Middle ground between the options in the following issue. Added a gradient overlay when you can scroll down. Not against adding the icon as well but IMO its a little confusing on if you can click on it or what.
Closes #774