Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Changing default params is not reflected in already planned schedules #1273

Open
1 of 5 tasks
MrJack91 opened this issue Apr 29, 2022 · 1 comment
Open
1 of 5 tasks
Labels
bug Something isn't working

Comments

@MrJack91
Copy link

MrJack91 commented Apr 29, 2022

Bug Description
If we change a default param in the UI, it's not updated for the already scheduled runs, even it's also visible in the schedules -> parameters dialog.
This can lead easily to wrongly configured flows which can damage a production environment.

Steps To Reproduce

  1. Setup a simple flow with a parameter.
  2. Setup the schedule -> you will see the yellow bars for the planned runs.
    • if you look there at the "run -> params" you will see there the default param
  3. Change the value of the parameters in "settings -> parameters -> default parameters -> set params"
  4. Checkup configuration in the scheduled runs. It still contains the old params.
  5. If you replan the schedule they will be updated.

Browsers Tested:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Notes
Open a scheduled run
2022-04-29_09h43_45

List params
2022-04-29_09h43_57

Change default value for the full flow
2022-04-29_09h44_16

In the "settings -> schedule-dialog" it displays the correct paramater value

  • (you need a reload of the page)*
    2022-04-29_09h44_47

If we open the scheduled run again, it is still the old parameter value
2022-04-29_09h45_12

@MrJack91 MrJack91 added the bug Something isn't working label Apr 29, 2022
@zhen0
Copy link
Member

zhen0 commented May 3, 2022

Thanks for the ticket @MrJack91 - as parameters are set at run creation (i.e. when a run is scheduled) this is part of the 1.0 design. You are correcting that toggling the schedule on and then off correctly resets parameters as it creates new runs. An update to the design could help make this more clear and such an issue is one that factors into planning for 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants