Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This repository has no history, making it hard to review #1

Open
eternaleye opened this issue Aug 12, 2017 · 0 comments
Open

This repository has no history, making it hard to review #1

eternaleye opened this issue Aug 12, 2017 · 0 comments

Comments

@eternaleye
Copy link

eternaleye commented Aug 12, 2017

This repository seems to be based on P-H-C/phc-winner-argon2 - however, it seems like the code was committed to an entirely new repository, losing the history and making it difficult to review the changes in isolation.

I've taken the liberty of integrating the changes over the commit that they seem to have been developed on top of (P-H-C/phc-winner-argon2@30c78a1) in eternaleye/Argon2-Practical-Graph:preserve-history, followed by rebasing them onto current master in eternaleye/Argon2-Practical-Graph:preserve-history-rebased.

I also changed the commenting-out of the distribution calculation to use #if 0, to minimize the amount of unnecessary churn (such as stripping the /* */ comment directives from comments in that section).

I'd appreciate if you'd review what I did to make sure I haven't made any mistakes, and possibly integrate the incremental form in this repository for ease of comprehension and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant