Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix deprecation of analytics in RTD #3761

Closed
wants to merge 1 commit into from

Conversation

laurenceisla
Copy link
Member

It seems to be working in the latest docs. This should make it work for the stable version.

@wolfgangwalther
Copy link
Member

Are you going to open PRs for v11 and v10 as well or should I backport it there, too?

@laurenceisla
Copy link
Member Author

Are you going to open PRs for v11 and v10 as well or should I backport it there, too?

Hmm... yes, I don't think there'd be an issue if backported to the v11 and v10 too. Go ahead.

@wolfgangwalther
Copy link
Member

I just found a setting in the "Addons" section at https://app.readthedocs.org/dashboard/postgrest/addons/edit/ called "Enable Analytics", which was not enabled.

Do we even need the additional code?

I tried enabling the addon, let's see whether this does anything to v12 docs without merging this PR first.

@laurenceisla
Copy link
Member Author

I tried enabling the addon, let's see whether this does anything to v12 docs without merging this PR first.

Ah, cool, let's check it out first. Strange that the RTD blog/changelog didn't mention that option.

@wolfgangwalther
Copy link
Member

RTD analytics seem to work alright, let's stick with those.

@laurenceisla laurenceisla deleted the docs-ga-v12 branch October 29, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants