Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config flag for enabling/disabling preferences #2987

Open
steve-chavez opened this issue Oct 3, 2023 · 1 comment
Open

Config flag for enabling/disabling preferences #2987

steve-chavez opened this issue Oct 3, 2023 · 1 comment
Labels
idea Needs of discussion to become an enhancement, not ready for implementation

Comments

@steve-chavez
Copy link
Member

Problem

Certain Prefer options need to be disabled in some cases, see #2777.

We also have a special config for Prefer: tx=commit, see db-tx-end.

Ideally we wouldn't need a special config for each case.

Proposal

Have a single config that enables or disables all preferences:

-- by default all preferences are enabled, so empty
server-preferences-disabled = ""

-- disable count: exact
server-preferences-disabled = "count=exact"

-- disable timezone
server-preferences-disabled = "timezone"

Notes

@steve-chavez steve-chavez added the idea Needs of discussion to become an enhancement, not ready for implementation label Oct 3, 2023
@wolfgangwalther
Copy link
Member

Maybe we can deprecate db-tx-end after this.

This setting does not translate 1:1 to the preferences-disabled, because it also set's a default value.

I'm undecided whether I find a shared preferences-disabled config a good or bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Needs of discussion to become an enhancement, not ready for implementation
Development

No branches or pull requests

2 participants