Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic for v1 and v2 #248

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Pydantic for v1 and v2 #248

wants to merge 5 commits into from

Conversation

csgulati09
Copy link
Collaborator

@csgulati09 csgulati09 commented Nov 27, 2024

Title: Pydantic versioning

Description:

  • Handled case of user's pydantic v1 dependency
  • Added types for beta.chat.completion
  • Added type for chat.completion
  • Added extra="allow" for all the types
  • Setting None as default value for the Optional Keys
  • Adding more type classes for the Threads route
  • Minimum required pydantic version 1.10.8 (advised to use 2.0 [suggested, as per pydantic docs])

Motivation:
User reported issue, pydantic version mismatch while using other SDKs

Related Issues:
Closes: #247 #252

@csgulati09 csgulati09 self-assigned this Nov 27, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:bug labels Nov 27, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cashfree-pg sdk is giving error with portkey-ai package
1 participant