diff --git a/app/controllers/gobierto_admin/gobierto_dashboards/dashboards_controller.rb b/app/controllers/gobierto_admin/gobierto_dashboards/dashboards_controller.rb deleted file mode 100644 index 966103f5fb..0000000000 --- a/app/controllers/gobierto_admin/gobierto_dashboards/dashboards_controller.rb +++ /dev/null @@ -1,14 +0,0 @@ -# frozen_string_literal: true - -module GobiertoAdmin - module GobiertoDashboards - class DashboardsController < GobiertoAdmin::BaseController - before_action { module_enabled!(current_site, "GobiertoDashboards") } - before_action -> { module_allowed_action!(current_admin, "GobiertoPlans", [:manage_dashboards, :view_dashboards]) } - - layout false - - def modal; end - end - end -end diff --git a/app/controllers/gobierto_admin/gobierto_plans/projects_controller.rb b/app/controllers/gobierto_admin/gobierto_plans/projects_controller.rb index 8aa99f1bc9..d4cbce0c06 100644 --- a/app/controllers/gobierto_admin/gobierto_plans/projects_controller.rb +++ b/app/controllers/gobierto_admin/gobierto_plans/projects_controller.rb @@ -200,7 +200,7 @@ def find_versioned_project end def set_dashboards_list_path - return unless current_site.configuration.gobierto_dashboards_enabled? && + return unless current_site.configuration.available_module?("GobiertoDashboards") && current_admin.module_allowed_action?(current_admin_module, current_site, :manage_dashboards) @dashboards_list_path ||= list_admin_plans_plan_dashboards_path(@plan) diff --git a/app/controllers/gobierto_admin/sites_controller.rb b/app/controllers/gobierto_admin/sites_controller.rb index 0a6cd60be7..22858f8b20 100644 --- a/app/controllers/gobierto_admin/sites_controller.rb +++ b/app/controllers/gobierto_admin/sites_controller.rb @@ -115,7 +115,7 @@ def find_site end def get_site_modules - APP_CONFIG[:site_modules].map { |site_module| OpenStruct.new(site_module) } + APP_CONFIG[:site_modules].union(Rails.configuration.engine_modules).map { |site_module| OpenStruct.new(site_module) } end def set_auth_modules diff --git a/app/controllers/gobierto_dashboards/api/v1/base_controller.rb b/app/controllers/gobierto_dashboards/api/v1/base_controller.rb deleted file mode 100644 index 60675508cf..0000000000 --- a/app/controllers/gobierto_dashboards/api/v1/base_controller.rb +++ /dev/null @@ -1,13 +0,0 @@ -# frozen_string_literal: true - -module GobiertoDashboards - module Api - module V1 - class BaseController < ApiBaseController - include ActionController::MimeResponds - - before_action { module_enabled!(current_site, "GobiertoDashboards", false) } - end - end - end -end diff --git a/app/controllers/gobierto_dashboards/api/v1/dashboards_controller.rb b/app/controllers/gobierto_dashboards/api/v1/dashboards_controller.rb deleted file mode 100644 index 74d6a8986d..0000000000 --- a/app/controllers/gobierto_dashboards/api/v1/dashboards_controller.rb +++ /dev/null @@ -1,152 +0,0 @@ -# frozen_string_literal: true - -module GobiertoDashboards - module Api - module V1 - class DashboardsController < BaseController - include ::GobiertoCommon::SecuredWithAdminToken - - skip_before_action :set_admin_with_token, only: [:index, :show, :data, :dashboard_data] - before_action :check_manage_dashboards, except: [:index, :show, :data, :dashboard_data] - - # GET /api/v1/dashboards - # GET /api/v1/dashboards.json - def index - render( - json: filtered_relation.active, - adapter: :json_api - ) - end - - # GET /api/v1/dashboards/1 - # GET /api/v1/dashboards/1.json - def show - find_active_resource - - render( - json: @resource, - adapter: :json_api - ) - end - - # GET /api/v1/dashboard_data?context=GobiertoPlans::Plan/1&data_pipe=project_metrics - # GET /api/v1/dashboard_data?context=GobiertoPlans::Plan/1&data_pipe=project_metrics.json - def dashboard_data - data = context_resource.present? && data_pipe.present? ? data_pipe.new(context_resource, site: current_site).output_data : [] - - render( - json: data - ) - end - - # GET /api/v1/dashboards/1/data - # GET /api/v1/dashboards/1/data.json - def data - find_active_resource - - render( - json: @resource, - serializer: ::GobiertoDashboards::DashboardDataSerializer, - adapter: :json_api - ) - end - - # GET /api/v1/dashboards/new - # GET /api/v1/dashboards/new.json - def new - render( - json: base_relation.active.new, - adapter: :json_api - ) - end - - # POST /api/v1/dashboards - # POST /api/v1/dashboards.json - def create - @form = form_class.new(resource_params.merge(site_id: current_site.id, admin_id: current_admin.id)) - - if @form.save - render( - json: @form.resource, - status: :created, - adapter: :json - ) - else - api_errors_render(@form, adapter: :json_api) - end - end - - # PATCH/PUT /api/v1/dashboards/1 - # PATCH/PUT /api/v1/dashboards/1.json - def update - find_resource - - @form = form_class.new(resource_params.merge(site_id: current_site.id, admin_id: current_admin.id, id: @resource.id)) - - if @form.save - render( - json: @form.resource, - adapter: :json - ) - else - api_errors_render(@form, adapter: :json_api) - end - end - - # DELETE /api/v1/dashboards/1 - # DELETE /api/v1/dashboards/1.json - def destroy - find_resource - - @resource.destroy - - head :no_content - end - - private - - def find_active_resource - @resource = (current_admin.present? ? base_relation : base_relation.active).find(params[:id]) - end - - def find_resource - @resource = base_relation.find(params[:id]) - end - - def data_pipe - return if params[:data_pipe].blank? - - "GobiertoDashboards::DataPipes::#{ params[:data_pipe].camelize }".constantize - rescue NameError - nil - end - - def context_resource - @context_resource ||= GobiertoCommon::ContextService.new(params[:context]) - end - - def base_relation - current_site.dashboards - end - - def filtered_relation - params[:context].present? ? base_relation.where(context: context_resource.context) : base_relation - end - - def form_class - DashboardForm - end - - def resource_params - ActiveModelSerializers::Deserialization.jsonapi_parse(params, only: [:title_translations, :title, :context, :widgets_configuration, :visibility_level]) - end - - def check_manage_dashboards - return if current_admin.manager? || current_admin.permissions.can?(:manage_dashboards) - - render(json: { message: "Unauthorized" }, status: :unauthorized, adapter: :json_api) - end - end - end - end -end diff --git a/app/controllers/gobierto_plans/plan_types_controller.rb b/app/controllers/gobierto_plans/plan_types_controller.rb index d8fe9bb38e..f56f6f5431 100644 --- a/app/controllers/gobierto_plans/plan_types_controller.rb +++ b/app/controllers/gobierto_plans/plan_types_controller.rb @@ -42,7 +42,7 @@ def sdg private def dashboards_enabled? - @dashboards_enabled ||= module_enabled?("GobiertoDashboards") && current_site.dashboards.active.for_context(@plan).exists? + @dashboards_enabled ||= module_enabled?("GobiertoDashboards") && defined?(GobiertoDashboards::Dashboard) && current_site.dashboards.active.for_context(@plan).exists? end def find_plan_type diff --git a/app/forms/gobierto_dashboards/dashboard_form.rb b/app/forms/gobierto_dashboards/dashboard_form.rb deleted file mode 100644 index 271f5cccb1..0000000000 --- a/app/forms/gobierto_dashboards/dashboard_form.rb +++ /dev/null @@ -1,118 +0,0 @@ -# frozen_string_literal: true - -module GobiertoDashboards - class DashboardForm < BaseForm - include ::GobiertoCore::TranslationsHelpers - include ActiveModel::Serialization - - attr_accessor( - :site_id, - :admin_id, - :widgets_configuration, - :context - ) - - attr_writer( - :id, - :title_translations, - :title, - :visibility_level - ) - - validate :context_presence - validates :title, :visibility_level, :site, presence: true - validates :title_translations, translated_attribute_presence: true - validates :visibility_level, inclusion: { in: Dashboard.visibility_levels.keys } - validate :widgets_configuration_json_format - - delegate :persisted?, to: :resource - - def resource - @resource ||= resource_class.find_by(id: @id) || build_resource - end - alias dashboard resource - - def site - @site ||= Site.find_by(id: site_id) - end - - def id - @id ||= resource.id - end - - def title_translations - @title_translations ||= (resource.title_translations || available_locales_blank_translations).tap do |translations| - translations[I18n.locale] = @title if @title.present? - end - end - - def title - title_translations.with_indifferent_access[I18n.locale].presence || title_translations.values.find(&:present?) - end - - def visibility_level - @visibility_level ||= resource.visibility_level || :draft - end - - def context_service - @context_service ||= GobiertoCommon::ContextService.new(context) - end - - def save - save_resource if valid? - end - - def available_visibility_levels - Dashboard.visibility_levels - end - - private - - def widgets_configuration_json_format - return if widgets_configuration.blank? || widgets_configuration.is_a?(Enumerable) - - @widgets_configuration = JSON.parse(widgets_configuration) - rescue JSON::ParserError - errors.add :widgets_configuration, I18n.t("errors.messages.invalid") - end - - def transformed_widgets_configuration - return if widgets_configuration.blank? - - widgets_configuration_json_format if widgets_configuration.is_a?(String) - - @widgets_configuration.map do |widget_configuration| - widget_configuration.merge(widget_configuration.slice("x", "y", "w", "h").transform_values(&:to_i)) - end - end - - def context_presence - errors.add(:context, I18n.t("errors.messages.not_found")) unless context_service.present? - end - - def build_resource - resource_class.new - end - - def resource_class - Dashboard - end - - def save_resource - @resource = resource.tap do |attributes| - attributes.site_id = site.id - attributes.title_translations = title_translations - attributes.context = context_service.context - attributes.visibility_level = visibility_level - attributes.widgets_configuration = transformed_widgets_configuration - end - - if @resource.save - @resource - else - promote_errors(@resource.errors) - false - end - end - end -end diff --git a/app/models/gobierto_dashboards/dashboard.rb b/app/models/gobierto_dashboards/dashboard.rb deleted file mode 100644 index 5c2861b94a..0000000000 --- a/app/models/gobierto_dashboards/dashboard.rb +++ /dev/null @@ -1,38 +0,0 @@ -# frozen_string_literal: true - -require_relative "../gobierto_dashboards" - -module GobiertoDashboards - class Dashboard < ApplicationRecord - belongs_to :site - - scope :sorted, -> { order(data_updated_at: :desc) } - scope :for_context, ->(resource) { where(context: resource.is_a?(String) ? GobiertoCommon::ContextService.new(resource).context : resource.to_global_id.to_s) } - - translates :title - - enum visibility_level: { draft: 0, active: 1 } - - validates :site, presence: true - - def custom_fields - site.custom_fields.where(uid: custom_field_uids) - end - - def custom_field_records - if context_resource.present? && site.custom_fields.where(instance: context_resource).exists? - site.custom_field_records.where(custom_fields: { uid: custom_fields_uids, instance: context_resource }) - else - site.custom_field_records.where(item: context_resource, custom_fields: { uid: custom_fields_uids }) - end - end - - def custom_fields_uids - widgets_configuration.map { |widget| widget["indicator"] }.compact - end - - def context_resource - @context_resource ||= GobiertoCommon::ContextService.new(context).resource - end - end -end diff --git a/app/models/gobierto_dashboards/data_pipes/base.rb b/app/models/gobierto_dashboards/data_pipes/base.rb deleted file mode 100644 index 88b6ced5ff..0000000000 --- a/app/models/gobierto_dashboards/data_pipes/base.rb +++ /dev/null @@ -1,22 +0,0 @@ -# frozen_string_literal: true - -require_relative "../../gobierto_dashboards" - -module GobiertoDashboards - module DataPipes - class Base - class NotImplementedError < StandardError; end - - attr_reader :site, :context - - def initialize(context, opts = {}) - @context = context.is_a?(GobiertoCommon::ContextService) ? context : GobiertoCommon::ContextService.new(:context) - @site = @context.present? && context.resource.respond_to?(:site) ? @context.resource.site : opts[:site] - end - - def output_data - raise NotImplementedError, "Override this with a method returning an ActiveRecord::Relation of a class with sortable concern" - end - end - end -end diff --git a/app/models/gobierto_dashboards/data_pipes/project_metrics.rb b/app/models/gobierto_dashboards/data_pipes/project_metrics.rb deleted file mode 100644 index 02d7c3dda4..0000000000 --- a/app/models/gobierto_dashboards/data_pipes/project_metrics.rb +++ /dev/null @@ -1,73 +0,0 @@ -# frozen_string_literal: true - -require_relative "../../gobierto_dashboards" - -module GobiertoDashboards - module DataPipes - class ProjectMetrics < Base - delegate :safe_parameterize, to: :class - - def output_data - { - data: indicator_names_disambiguation(custom_field_records.map { |record| indicators(record) }.compact.flatten) - }.to_json - end - - def self.safe_parameterize(text) - ActiveSupport::Inflector.transliterate(text).parameterize - end - - private - - def custom_fields - site.custom_fields.find_by(**custom_field_condition) - end - - def custom_field_records - site.custom_field_records.where(custom_fields: custom_field_condition) - end - - def custom_field_condition - @custom_field_condition ||= { instance: @context.resource, uid: "project-metrics" } - end - - def indicators(record) - published_version = record.item.published_version - return unless published_version.present? - - published_value = ::GobiertoCommon::CustomFieldFunctions::Indicator.new(record, version: published_version).value - return unless published_value.is_a? Array - - published_project = ::GobiertoPlans::ProjectDecorator.new(record.item, opts: { plan: @context.resource }).at_current_version - project = published_project.to_global_id.to_s - project_name = published_project.name - grouped_values(published_value).map do |key, values| - { - name: values.first["indicator"].strip.squeeze(" "), - id: key, - project: project, - project_name: project_name, - values: values.map { |value| value.except("indicator") } - } - end - end - - def indicator_names_disambiguation(data) - names = data.map { |indicator| indicator[:name] } - duplicated_names = names.group_by(&:itself).select { |_, v| v.size > 1 }.map(&:first) - - data.map do |indicator| - next indicator unless duplicated_names.include? indicator[:name] - - indicator.merge(name: "#{indicator[:project_name]} - #{indicator[:name]}") - end - end - - def grouped_values(values) - values.group_by do |row| - safe_parameterize(row["indicator"]) - end - end - end - end -end diff --git a/app/serializers/gobierto_dashboards/base_serializer.rb b/app/serializers/gobierto_dashboards/base_serializer.rb deleted file mode 100644 index 9a0961ff51..0000000000 --- a/app/serializers/gobierto_dashboards/base_serializer.rb +++ /dev/null @@ -1,25 +0,0 @@ -# frozen_string_literal: true - -module GobiertoDashboards - class BaseSerializer < ActiveModel::Serializer - def current_site - object.site - end - - def exclude_links? - instance_options[:exclude_links] - end - - def exclude_relationships? - instance_options[:exclude_relationships] - end - - def with_translations? - instance_options[:with_translations] - end - - def include_draft? - instance_options[:include_draft] - end - end -end diff --git a/app/serializers/gobierto_dashboards/custom_field_record_data_serializer.rb b/app/serializers/gobierto_dashboards/custom_field_record_data_serializer.rb deleted file mode 100644 index 8ee68a41ba..0000000000 --- a/app/serializers/gobierto_dashboards/custom_field_record_data_serializer.rb +++ /dev/null @@ -1,19 +0,0 @@ -# frozen_string_literal: true - -module GobiertoDashboards - class CustomFieldRecordDataSerializer < BaseSerializer - attribute :name do - object.custom_field.uid - end - - attribute :item do - next unless object.item.present? - - object.item.to_global_id.to_s - end - - attribute :values do - object.value - end - end -end diff --git a/app/serializers/gobierto_dashboards/dashboard_data_serializer.rb b/app/serializers/gobierto_dashboards/dashboard_data_serializer.rb deleted file mode 100644 index d81bfb7ecc..0000000000 --- a/app/serializers/gobierto_dashboards/dashboard_data_serializer.rb +++ /dev/null @@ -1,17 +0,0 @@ -# frozen_string_literal: true - -module GobiertoDashboards - class DashboardDataSerializer < BaseSerializer - attribute :values - - def values - object.custom_field_records.map do |record| - { - name: record.custom_field.uid, - item: record.item.to_global_id.to_s, - values: record.value - } - end - end - end -end diff --git a/app/serializers/gobierto_dashboards/dashboard_serializer.rb b/app/serializers/gobierto_dashboards/dashboard_serializer.rb deleted file mode 100644 index 0821e94381..0000000000 --- a/app/serializers/gobierto_dashboards/dashboard_serializer.rb +++ /dev/null @@ -1,11 +0,0 @@ -# frozen_string_literal: true - -module GobiertoDashboards - class DashboardSerializer < BaseSerializer - include Rails.application.routes.url_helpers - - attribute :title, unless: :with_translations? - attribute :title_translations, if: :with_translations? - attributes :visibility_level, :context, :widgets_configuration - end -end diff --git a/app/views/gobierto_admin/gobierto_dashboards/dashboards/list_modal.html.erb b/app/views/gobierto_admin/gobierto_dashboards/dashboards/list_modal.html.erb deleted file mode 100644 index a6f5bc46f7..0000000000 --- a/app/views/gobierto_admin/gobierto_dashboards/dashboards/list_modal.html.erb +++ /dev/null @@ -1,51 +0,0 @@ -
-

<%= t(".title") %>

-
- <% if @dashboards.present? %> -
- <%= select_tag( - :dashboard, - options_for_select(@dashboards.map do |dashboard| - [dashboard.title, dashboard.id, data: { preview_path: dashboard_preview_path(dashboard) }] - end), - data: { behavior: "select2" } - ) - %> -
-
- <%= link_to( - t(".add"), - admin_dashboards_modal_path( - id: @dashboards.first&.id, - context: @context, - pipe: @data_pipe, - indicator: GobiertoDashboards::DataPipes::ProjectMetrics.safe_parameterize(params[:indicator]), - indicator_context: params[:indicator_context], - preview_path: dashboard_preview_path(@dashboards.first) - ), - id: "add-current-dashboard-btn", - data: { "dashboards-maker": true }, - class: "open_remote_modal button" - ) %> -
- <% else %> -
- <%= t(".no_dashboards") %> -
- <% end %> -
-
- <%= link_to( - t(".new"), - admin_dashboards_modal_path( - context: @context, - pipe: @data_pipe, - indicator: GobiertoDashboards::DataPipes::ProjectMetrics.safe_parameterize(params[:indicator]), - indicator_context: params[:indicator_context] - ), - data: { "dashboards-maker": true }, - class: "open_remote_modal" - ) %> -
-
-
diff --git a/app/views/gobierto_admin/gobierto_dashboards/dashboards/modal.html.erb b/app/views/gobierto_admin/gobierto_dashboards/dashboards/modal.html.erb deleted file mode 100644 index 64d5ea651f..0000000000 --- a/app/views/gobierto_admin/gobierto_dashboards/dashboards/modal.html.erb +++ /dev/null @@ -1,14 +0,0 @@ -
-
- data-id="<%= params[:id] %>" - <% end %> - <% if params[:indicator].present? %> - data-indicator="<%= params[:indicator] %>" - data-indicator-context="<%= params[:indicator_context] %>" - <% end %> /> -
\ No newline at end of file diff --git a/app/views/gobierto_admin/gobierto_plans/shared/_navigation.html.erb b/app/views/gobierto_admin/gobierto_plans/shared/_navigation.html.erb index 458f200f95..7206350f12 100644 --- a/app/views/gobierto_admin/gobierto_plans/shared/_navigation.html.erb +++ b/app/views/gobierto_admin/gobierto_plans/shared/_navigation.html.erb @@ -13,7 +13,7 @@ <%= link_to t(".projects_tab"), admin_plans_plan_projects_path(@plan), data: { turbolinks: false } %> <% end %> - <% if current_site.configuration.gobierto_dashboards_enabled? && current_admin.module_allowed_action?("GobiertoPlans", current_site, [:view_dashboards, :manage_dashboards]) %> + <% if current_site.configuration.available_module?("GobiertoDashboards") && current_admin.module_allowed_action?("GobiertoPlans", current_site, [:view_dashboards, :manage_dashboards]) %>
  • "> <%= link_to t(".dashboards_tab"), admin_plans_plan_dashboards_path(@plan), data: { turbolinks: false } %>
    • diff --git a/config/application.rb b/config/application.rb index 83dcfb5aa9..10ebc44afd 100644 --- a/config/application.rb +++ b/config/application.rb @@ -74,6 +74,7 @@ class Application < Rails::Application config.engine_sass_config_overrides = [] config.engine_sass_theme_dependencies = [] config.gobierto_engines_themes = {} + config.engine_modules = [] # Custom field plugins config.custom_field_plugins = {} diff --git a/config/initializers/app_config.rb b/config/initializers/app_config.rb index 0a7ad05981..1aed124c27 100644 --- a/config/initializers/app_config.rb +++ b/config/initializers/app_config.rb @@ -2,7 +2,7 @@ APP_CONFIG = Rails.application.config_for(:application).with_indifferent_access -SITE_MODULES = APP_CONFIG[:site_modules].map do |site_module| +SITE_MODULES = APP_CONFIG[:site_modules].union(Rails.configuration.engine_modules).map do |site_module| site_module[:namespace] end diff --git a/test/controllers/gobierto_dashboards/api/v1/dashboards_controller_test.rb b/test/controllers/gobierto_dashboards/api/v1/dashboards_controller_test.rb deleted file mode 100644 index 9ab77a903a..0000000000 --- a/test/controllers/gobierto_dashboards/api/v1/dashboards_controller_test.rb +++ /dev/null @@ -1,574 +0,0 @@ -# frozen_string_literal: true - -require "test_helper" -require "support/concerns/api/api_protection_test" - -module GobiertoDashboards - module Api - module V1 - class DashboardsControllerTest < GobiertoControllerTest - include ::Api::ApiProtectionTest - - def setup - super - - admin_without_write_permissions.admin_groups << view_dashboards_admin_group - admin_with_write_permissions.admin_groups << manage_dashboards_admin_group - - setup_api_protection_test( - path: gobierto_dashboards_api_v1_dashboards_path, - site: site, - admin: admin, - token_with_domain: gobierto_admin_api_tokens(:tony_domain), - token_with_other_domain: gobierto_admin_api_tokens(:tony_other_domain) - ) - end - - def publish_last_version_on_all_projects! - plan.nodes.each do |project| - project.touch - project.published_version = project.versions.count - project.published! - end - plan.touch - end - - def site - @site ||= sites(:madrid) - end - - def user - @user ||= users(:dennis) - end - - def view_dashboards_admin_group - @view_dashboards_admin_group ||= gobierto_admin_admin_groups(:madrid_view_plans_dashboards_group) - end - - def manage_dashboards_admin_group - @manage_dashboards_admin_group ||= gobierto_admin_admin_groups(:madrid_manage_plans_dashboards_group) - end - - def user_auth_header - @user_auth_header ||= "Bearer #{user_api_tokens(:dennis_primary_api_token)}" - end - - def admin_auth_header - @admin_auth_header ||= "Bearer #{admin.primary_api_token}" - end - alias admin_with_write_permissions_auth_header admin_auth_header - - def admin_without_write_permissions_auth_header - @admin_without_write_permissions_auth_header ||= "Bearer #{admin_without_write_permissions.primary_api_token}" - end - - def admin - @admin ||= gobierto_admin_admins(:tony) - end - alias admin_with_write_permissions admin - - def admin_without_write_permissions - @admin_without_write_permissions ||= gobierto_admin_admins(:steve) - end - - def site_with_module_disabled - @site_with_module_disabled ||= sites(:santander) - end - - def active_dashboards_count - @active_dashboards_count ||= site.dashboards.active.count - end - - def dashboard - @dashboard ||= gobierto_dashboards_dashboards(:urban_planning) - end - alias project_dashboard dashboard - - def other_dashboard - @other_dashboard ||= gobierto_dashboards_dashboards(:indicators) - end - alias plan_dashboard other_dashboard - - def draft_dashboard - @draft_dashboard ||= gobierto_dashboards_dashboards(:draft_dashboard) - end - - def plan - @plan ||= gobierto_plans_plans(:dashboards_plan) - end - - def plan_custom_fields_records - @plan_custom_fields_records ||= site.custom_field_records.where(custom_fields: { instance: plan }) - end - - def project - @project ||= gobierto_plans_nodes(:dashboard_project) - end - - def project_custom_fields_records - @project_custom_fields_records ||= site.custom_field_records.where(item: project) - end - - def other_project - @other_project ||= gobierto_plans_nodes(:dashboard_alternative_project) - end - - def other_project_custom_fields_records - @other_project_custom_fields_records ||= site.custom_field_records.where(item: other_project) - end - - def single_indicator_name - @single_indicator_name ||= "Decretos Emitidos" - end - - def indicator_name_present_in_different_processes - @indicator_name_present_in_different_processes ||= "Expedientes cerrados" - end - - def test_index_with_module_disabled - with(site: site_with_module_disabled) do - get gobierto_dashboards_api_v1_dashboards_path - - assert_response :forbidden - end - end - - def valid_params(except: [], with_custom_attributes: {}) - { - data: - { - type: "gobierto_dashboards-dashboards", - attributes: valid_attributes.except(*except).merge(with_custom_attributes) - } - } - end - - def valid_attributes - { - title_translations: { - en: "New dashboard", - es: "Nuevo cuadro de mando" - }, - visibility_level: "active", - context: plan.to_global_id.to_s, - widgets_configuration: - [ - { - i: "203888c6-338d-4c82-9053-2e5ce0d80391", - type: "HTML", - x: 0, - y: 0, - w: 12, - h: 4, - raw: - "

    Wadus

    This is a test

    " - }, - { - i: "768f8ed8-d08a-4048-bc67-b5dadaeb09bd", - type: "INDICATOR", - x: 0, - y: 3, - w: 6, - h: 7, - indicator: "Decretos Emitidos", - subtype: "individual" - }, - { - i: "768f8ed8-d08a-4048-bc67-b5dadaeb09bd", - type: "INDICATOR", - x: 0, - y: 3, - w: 6, - h: 7, - indicator: "Camas UCI", - subtype: "individual" - } - ] - } - end - - # GET /api/v1/dashboards - def test_index - with(site: site) do - get gobierto_dashboards_api_v1_dashboards_path, as: :json - - assert_response :success - - response_data = response.parsed_body - - assert response_data.has_key? "data" - assert_equal active_dashboards_count, response_data["data"].count - dashboards_titles = response_data["data"].map { |item| item.dig("attributes", "title") } - assert_includes dashboards_titles, dashboard.title - item = response_data["data"][dashboards_titles.index(dashboard.title)]["attributes"] - %w(title context visibility_level widgets_configuration).each do |attribute| - assert_equal dashboard.send(attribute), item[attribute] - end - end - end - - # GET /api/v1/dashboards?context=Module::Model/ID - def test_index_with_context - with(site: site) do - get gobierto_dashboards_api_v1_dashboards_path, params: { context: "GobiertoPlans::Plan/#{plan.id}" }, as: :json - - assert_response :success - - response_data = response.parsed_body - - assert response_data.has_key? "data" - assert_equal 1, response_data["data"].count - dashboards_titles = response_data["data"].map { |item| item.dig("attributes", "title") } - assert_includes dashboards_titles, plan_dashboard.title - end - end - - # GET /api/v1/dashboards?context=gobierto/Module::Model/ID - # GET /api/v1/dashboards?context=gid://gobierto/Module::Model/ID - def test_index_with_full_global_id_context - with(site: site) do - get gobierto_dashboards_api_v1_dashboards_path, params: { context: "gobierto/GobiertoPlans::Node/#{project.id}" }, as: :json - assert_response :success - response_data = response.parsed_body - - get gobierto_dashboards_api_v1_dashboards_path, params: { context: "gobierto/GobiertoPlans::Node/#{project.id}" }, as: :json - assert_response :success - full_gid_response_data = response.parsed_body - - assert_equal full_gid_response_data, response_data - - assert response_data.has_key? "data" - assert_equal 1, response_data["data"].count - dashboards_titles = response_data["data"].map { |item| item.dig("attributes", "title") } - assert_includes dashboards_titles, project_dashboard.title - end - end - - # GET /api/v1/dashboards?context=wadus - def test_index_with_not_existing_context - with(site: site) do - get gobierto_dashboards_api_v1_dashboards_path, params: { context: "wadus" }, as: :json - - assert_response :success - - response_data = response.parsed_body - - assert response_data.has_key? "data" - assert_equal [], response_data["data"] - end - end - - # GET /api/v1/dashboards/1 - def test_show - with(site: site) do - get gobierto_dashboards_api_v1_dashboard_path(dashboard), as: :json - - assert_response :success - - response_data = response.parsed_body - - assert response_data.has_key? "data" - assert_equal dashboard.id, response_data["data"]["id"].to_i - item = response_data["data"]["attributes"] - %w(title context visibility_level widgets_configuration).each do |attribute| - assert_equal dashboard.send(attribute), item[attribute] - end - end - end - - def test_show_draft - with(site: site) do - get gobierto_dashboards_api_v1_dashboard_path(draft_dashboard) - - assert_response :not_found - - get gobierto_dashboards_api_v1_dashboard_path(draft_dashboard), headers: { Authorization: admin_auth_header } - - assert_response :success - end - end - - # GET /api/v1/dashboards/1/data - def test_dashboard_data_of_plan_dashboard - with(site: site) do - get data_gobierto_dashboards_api_v1_dashboard_path(plan_dashboard), as: :json - - assert_response :success - - response_data = response.parsed_body - - assert response_data.has_key? "data" - assert_equal plan_dashboard.id, response_data["data"]["id"].to_i - item_data = response_data["data"]["attributes"] - - plan_custom_fields_record_values = plan_custom_fields_records.map(&:value) - plan_custom_fields_uids = plan_custom_fields_records.map { |record| record.custom_field.uid }.uniq - plan_projects = plan.nodes - - item_data["values"].each do |record| - assert_includes plan_custom_fields_record_values, record["values"] - assert_includes plan_custom_fields_uids, record["name"] - assert_includes plan_projects, GlobalID::Locator.locate(record["item"]) - end - end - end - - # GET /api/v1/dashboard_data?context=GobiertoPlans::Plan/1&data_pipe=project_metrics - def test_dashboard_data_project_metrics_data_pipe - publish_last_version_on_all_projects! - with(site: site) do - get gobierto_dashboards_api_v1_dashboard_data_path, params: { context: "GobiertoPlans::Plan/#{plan.id}", data_pipe: "project_metrics" } - - assert_response :success - - response_body = response.parsed_body - - assert response_body.has_key? "data" - response_data = response_body["data"] - - indicator_names = response_data.map { |indicator| indicator["name"] } - indicator_ids = response_data.map { |indicator| indicator["id"] } - - assert_includes indicator_names, single_indicator_name - assert_includes indicator_ids, single_indicator_name.parameterize - refute_includes indicator_names, indicator_name_present_in_different_processes - assert_includes indicator_ids, indicator_name_present_in_different_processes.parameterize - - single_indicator_name_values = response_data.find { |indicator| indicator["id"] == single_indicator_name.parameterize }["values"] - - project_custom_field_record_single_indicator_name_values = project_custom_fields_records.map do |record| - record.value.select do |row| - /decretos\s*emitidos/i =~ row["indicator"] - end - end.flatten - - assert_equal project_custom_field_record_single_indicator_name_values.length, single_indicator_name_values.length - - project_custom_field_record_single_indicator_name_values.each do |value| - assert_includes single_indicator_name_values, value.except("indicator") - end - end - end - - def test_dashboard_data_project_metrics_data_pipe_with_versions - with(site: site) do - get gobierto_dashboards_api_v1_dashboard_data_path, params: { context: "GobiertoPlans::Plan/#{plan.id}", data_pipe: "project_metrics" } - - assert_response :success - - response_body = response.parsed_body - - assert response_body.has_key? "data" - response_data = response_body["data"] - assert_equal [], response_data - - publish_last_version_on_all_projects! - - get gobierto_dashboards_api_v1_dashboard_data_path, params: { context: "GobiertoPlans::Plan/#{plan.id}", data_pipe: "project_metrics" } - - assert_response :success - - response_body = response.parsed_body - - assert response_body.has_key? "data" - response_data = response_body["data"] - refute_equal [], response_data - indicator_names = response_data.map { |indicator| indicator["name"] } - - assert_includes indicator_names, single_indicator_name - end - end - - def test_dashboard_data_of_project_dashboard - with(site: site) do - get data_gobierto_dashboards_api_v1_dashboard_path(project_dashboard), as: :json - - assert_response :success - - response_data = response.parsed_body - - assert response_data.has_key? "data" - assert_equal project_dashboard.id, response_data["data"]["id"].to_i - item_data = response_data["data"]["attributes"] - - project_custom_fields_record_values = project_custom_fields_records.map(&:value) - other_project_custom_fields_record_values = other_project_custom_fields_records.map(&:value) - - item_data["values"].each do |record| - assert_includes project_custom_fields_record_values, record["values"] - refute_includes other_project_custom_fields_record_values, record["values"] - assert_equal project, GlobalID::Locator.locate(record["item"]) - end - end - end - - def test_dashboard_data_only_includes_data_related_with_the_context - with(site: site) do - plan_dashboard.update_attribute(:widgets_configuration, valid_attributes[:widgets_configuration]) - - get data_gobierto_dashboards_api_v1_dashboard_path(plan_dashboard), as: :json - - assert_response :success - - response_data = response.parsed_body - - assert response_data.has_key? "data" - item_data = response_data["data"]["attributes"] - - plan_projects = plan.nodes - - item_data["values"].each do |record| - assert_equal "indicator-0", record["name"] - assert_includes plan_projects, GlobalID::Locator.locate(record["item"]) - end - end - end - - def test_permissions_of_admin_actions - with(site: site) do - post gobierto_dashboards_api_v1_dashboards_path, params: valid_params - assert_response :unauthorized - - get new_gobierto_dashboards_api_v1_dashboard_path - assert_response :unauthorized - - put gobierto_dashboards_api_v1_dashboard_path(dashboard), params: valid_params - assert_response :unauthorized - - delete gobierto_dashboards_api_v1_dashboard_path(dashboard) - assert_response :unauthorized - - post gobierto_dashboards_api_v1_dashboards_path, headers: { Authorization: user_auth_header }, params: valid_params - assert_response :unauthorized - - get new_gobierto_dashboards_api_v1_dashboard_path, headers: { Authorization: user_auth_header } - assert_response :unauthorized - - put gobierto_dashboards_api_v1_dashboard_path(dashboard), headers: { Authorization: user_auth_header }, params: valid_params - assert_response :unauthorized - - delete gobierto_dashboards_api_v1_dashboard_path(dashboard), headers: { Authorization: user_auth_header } - assert_response :unauthorized - end - end - - def test_permissions_of_regular_admin_without_write_permissions - with(site: site) do - post gobierto_dashboards_api_v1_dashboards_path, headers: { Authorization: admin_without_write_permissions_auth_header }, params: valid_params - assert_response :unauthorized - - post gobierto_dashboards_api_v1_dashboards_path, headers: { Authorization: admin_with_write_permissions_auth_header }, params: valid_params - assert_response :created - end - end - - # GET /api/v1/dashboards/new - def test_new - with(site: site) do - get new_gobierto_dashboards_api_v1_dashboard_path, headers: { Authorization: admin_auth_header }, as: :json - - assert_response :success - - response_data = response.parsed_body - - assert response_data.has_key? "data" - item = response_data["data"]["attributes"] - %w(title context visibility_level widgets_configuration).each do |attribute| - assert item.has_key?(attribute) - end - end - end - - # POST /api/v1/dashboards - def test_create_without_context - with(site: site) do - assert_no_difference "GobiertoDashboards::Dashboard.count" do - post gobierto_dashboards_api_v1_dashboards_path, headers: { Authorization: admin_auth_header }, params: valid_params(except: [:context]) - assert_response :unprocessable_entity - assert_match "not found", response.parsed_body.to_json - end - end - end - - def test_create_with_invalid_context - with(site: site) do - assert_no_difference "GobiertoDashboards::Dashboard.count" do - post( - gobierto_dashboards_api_v1_dashboards_path, - headers: { Authorization: admin_auth_header }, - params: valid_params(with_custom_attributes: { context: "GobiertoPlans::Plan/123456" }) - ) - assert_response :unprocessable_entity - assert_match "not found", response.parsed_body.to_json - end - end - end - - def test_create - with(site: site) do - assert_difference "GobiertoDashboards::Dashboard.count", 1 do - post( - gobierto_dashboards_api_v1_dashboards_path, - headers: { Authorization: admin_auth_header }, - params: valid_params - ) - assert_response :created - end - - new_dashboard = GobiertoDashboards::Dashboard.last - - assert_equal valid_attributes[:title_translations][:en], new_dashboard.title_en - assert_equal valid_attributes[:title_translations][:es], new_dashboard.title_es - assert_equal valid_attributes[:context], new_dashboard.context - valid_attributes[:widgets_configuration].zip(new_dashboard.widgets_configuration).each do |original_widget, stored_widget| - assert_equal stored_widget.sort, original_widget.deep_stringify_keys.sort - end - assert new_dashboard.active? - end - end - - def test_create_with_incomplete_valid_gid - with(site: site) do - assert_difference "GobiertoDashboards::Dashboard.count", 1 do - post( - gobierto_dashboards_api_v1_dashboards_path, - headers: { Authorization: admin_auth_header }, - params: valid_params(with_custom_attributes: { context: "GobiertoPlans::Plan/#{plan.id}" }) - ) - assert_response :created - end - end - end - - # PUT/PATCH /api/v1/dashboards/1 - def test_update - with(site: site) do - put gobierto_dashboards_api_v1_dashboard_path(dashboard), headers: { Authorization: admin_auth_header }, params: valid_params - - dashboard.reload - assert_equal valid_attributes[:title_translations][:en], dashboard.title_en - assert_equal valid_attributes[:title_translations][:es], dashboard.title_es - assert_equal valid_attributes[:context], dashboard.context - valid_attributes[:widgets_configuration].zip(dashboard.widgets_configuration).each do |original_widget, stored_widget| - assert_equal stored_widget.sort, original_widget.deep_stringify_keys.sort - end - assert dashboard.active? - end - end - - def test_destroy - id = dashboard.id - - assert_difference "GobiertoDashboards::Dashboard.count", -1 do - with(site: site) do - delete gobierto_dashboards_api_v1_dashboard_path(id), headers: { Authorization: admin_auth_header } - assert_response :no_content - end - - refute GobiertoDashboards::Dashboard.where(id: id).exists? - end - end - end - end - end -end diff --git a/test/fixtures/gobierto_dashboards/dashboards.yml b/test/fixtures/gobierto_dashboards/dashboards.yml deleted file mode 100644 index 19214380b8..0000000000 --- a/test/fixtures/gobierto_dashboards/dashboards.yml +++ /dev/null @@ -1,130 +0,0 @@ -urban_planning: - site: madrid - title_translations: <%= { en: "Urban planning dashboard", es: "Cuadro de mando de urbanismo" }.to_json %> - context: <%= "gid://gobierto/GobiertoPlans::Node/#{ ActiveRecord::FixtureSet.identify(:dashboard_project) }" %> - visibility_level: <%= GobiertoDashboards::Dashboard.visibility_levels["active"] %> - widgets_configuration: <%= - [ - { - i: "203888c6-338d-4c82-9053-2e5ce0d80391", - type: "HTML", - x: 0, - y: 0, - w: 12, - h: 4, - raw: - "

    Culpa amet quis voluptate cillum.

    Lorem anim elit tempor consectetur labore consectetur eiusmod cupidatat mollit sit labore incididunt minim. Et anim quis quis do veniam. Excepteur ipsum anim id consectetur duis nisi ullamco velit eiusmod cupidatat. Dolore fugiat voluptate duis ex irure sunt dolor excepteur nulla. Nisi ea non sint excepteur duis occaecat. Voluptate dolore do duis labore tempor deserunt ex occaecat veniam esse id est dolor.\r\n

    " - }, - { - i: "768f8ed8-d08a-4048-bc67-b5dadaeb09bd", - type: "INDICATOR", - x: 0, - y: 3, - w: 6, - h: 7, - indicator: "indicator-0", - subtype: "individual" - }, - { - i: "768f8ed8-d08a-4048-bc67-b50909eb09bd", - type: "INDICATOR", - x: 6, - y: 3, - w: 6, - h: 9, - indicator: "indicator-0", - subtype: "table" - } - ].to_json - %> - -indicators: - site: madrid - title_translations: <%= { en: "Indicators", es: "Indicadores" }.to_json %> - context: <%= "gid://gobierto/GobiertoPlans::Plan/#{ ActiveRecord::FixtureSet.identify(:dashboards_plan) }" %> - visibility_level: <%= GobiertoDashboards::Dashboard.visibility_levels["active"] %> - widgets_configuration: <%= - [ - { - type: "HTML", - w: 6, - h: 9, - i: "7210b284-f42d-4dc5-a3d9-a3e76d540e43", - x: 0, - y: 0, - raw: - "

    Nulla irure minim minim aliqua ex occaecat aliqua laborum minim laborum anim aute id magna.

    Sunt minim dolore occaecat ut consequat non mollit. Ea non eiusmod anim laborum sint aute tempor nisi adipisicing ex consectetur consequat. Ex ullamco Lorem aliqua incididunt culpa labore dolor dolor dolor magna sit. Laborum sint sit nostrud nostrud laboris quis eiusmod duis exercitation magna consequat ex cupidatat exercitation. Elit fugiat aliqua est elit proident veniam commodo commodo qui cupidatat fugiat esse. Mollit velit indicator-0 commodo proident nisi excepteur labore laboris. Enim et aute elit nulla elit laborum sit laboris eiusmod voluptate consequat dolor laborum laborum.\r\n

    " - }, - { - i: "768f8ed8-d08a-4048-bc67-b50909eb09bd", - type: "INDICATOR", - x: 6, - y: 3, - w: 6, - h: 9, - indicator: "Decretos Emitidos", - subtype: "table" - }, - { - x: 6, - y: 0, - i: "INDICATOR-67y6q7", - type: "INDICATOR", - w: 6, - h: 9, - indicator: "Camas UCI", - subtype: "individual" - }, - { - h: 9, - i: "INDICATOR-7f8zl1", - w: 6, - x: 0, - y: 9, - type: "indicator", - min_h: 3, - min_w: 4, - subtype: "table", - indicator: "Dashboards alternative project - Expedientes cerrados" - } - ].to_json - %> - -draft_dashboard: - site: madrid - title_translations: <%= { en: "Draft dashboard", es: "Borrador de cuadro de mando" }.to_json %> - visibility_level: <%= GobiertoDashboards::Dashboard.visibility_levels["draft"] %> - widgets_configuration: <%= - [ - { - i: "203888c6-338d-4c82-9053-2e5ce0d80391", - type: "HTML", - x: 0, - y: 0, - w: 12, - h: 4, - raw: - "

    CulpapapapoCulpa amet quis voluptate cillum.

    Lorem anim elit tempor consectetur labore consectetur eiusmod cupidatat mollit sit labore incididunt minim. Et anim quis quis do veniam. Excepteur ipsum anim id consectetur duis nisi ullamco velit eiusmod cupidatat. Dolore fugiat voluptate duis ex irure sunt dolor excepteur nulla. Nisi ea non sint excepteur duis occaecat. Voluptate dolore do duis labore tempor deserunt ex occaecat veniam esse id est dolor.\r\n

    " - }, - { - i: "768f8ed8-d08a-4048-bc67-b5dadaeb09bd", - type: "INDICATOR", - x: 0, - y: 3, - w: 6, - h: 7, - indicator: "indicator-0", - subtype: "individual" - }, - { - i: "768f8ed8-d08a-4048-bc67-b50909eb09bd", - type: "INDICATOR", - x: 6, - y: 3, - w: 6, - h: 9, - indicator: "indicator-0", - subtype: "table" - } - ].to_json - %>